Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nxos_bgp_neighbor_af:sanity:6k: skip soft-reconfig 'always' test #55661

Merged
merged 1 commit into from Apr 24, 2019
Merged

nxos_bgp_neighbor_af:sanity:6k: skip soft-reconfig 'always' test #55661

merged 1 commit into from Apr 24, 2019

Conversation

chrisvanheuveln
Copy link
Contributor

@chrisvanheuveln chrisvanheuveln commented Apr 23, 2019 •
edited

SUMMARY

N5K / N6K do not support the always keyword on the soft-reconfig in configuration.

Modify sanity.yaml to omit the always for these platforms.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

modules/network/nxos/nxos_bgp_neighbor_af

ADDITIONAL INFORMATION

All nxos_bgp_neighbor_af sanity tests now pass for N6K.

@chrisvanheuveln
nxos_bgp_neighbor_af:sanity:6k: skip soft-reconfig 'always' test
a9a7a9a 
N5K / N6K do not support the `always` keyword on the `soft-reconfig in` configuration.
@ansibot
Copy link
Contributor

ansibot commented Apr 23, 2019

cc @GGabriele @mikewiebe @rahushen @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels Apr 23, 2019
@trishnaguha trishnaguha self-assigned this Apr 24, 2019
@trishnaguha trishnaguha removed the needs_triage Needs a first human triage before being processed. label Apr 24, 2019
@trishnaguha trishnaguha merged commit 4798368 into ansible:devel Apr 24, 2019
trishnaguha pushed a commit to trishnaguha/ansible that referenced this pull request May 13, 2019
@chrisvanheuveln @trishnaguha
nxos_bgp_neighbor_af:sanity:6k: skip soft-reconfig 'always' test (ans…
2da2738 
…ible#55661)

N5K / N6K do not support the `always` keyword on the `soft-reconfig in` configuration.

(cherry picked from commit 4798368)
abadger pushed a commit that referenced this pull request May 21, 2019
@chrisvanheuveln @abadger
nxos_bgp_neighbor_af:sanity:6k: skip soft-reconfig 'always' test (#55661
faee6a3 
)

N5K / N6K do not support the `always` keyword on the `soft-reconfig in` configuration.

(cherry picked from commit 4798368)
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
@chrisvanheuveln chrisvanheuveln deleted the devel-nxos_bgp_neighbor_af branch October 30, 2019 12:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trishnaguha trishnaguha trishnaguha approved these changes

Assignees

@trishnaguha trishnaguha

Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chrisvanheuveln @ansibot @trishnaguha