Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nxos_interface: Fix admin_state check for n6k #55673

Merged
merged 2 commits into from May 8, 2019
Merged

nxos_interface: Fix admin_state check for n6k #55673

merged 2 commits into from May 8, 2019

Conversation

mikewiebe
Copy link
Contributor

@mikewiebe mikewiebe commented Apr 23, 2019 •
edited

SUMMARY

This PR fixes two problems with the nxos_interface module:

  • Certain NX-OS platforms like the N6k do not have the admin_state key as part of the structured output for the show interface command.
    • This update makes use of other keys that are available to determine the admin state of the interface.
  • This also fixes a problem with the tx_rate negative test. The counters can be greater then 0 when the test runs so we first clear the counters and then set test rate to a high value to ensure the test fails.
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

nxos_interface

ADDITIONAL INFORMATION

Tested on N3k, N6k, N7k, N9k platforms

@mikewiebe mikewiebe changed the title [WIP] Fix admin_state check for n6k [WIP] nxos_interface: Fix admin_state check for n6k Apr 23, 2019
@ansibot
Copy link
Contributor

ansibot commented Apr 23, 2019

cc @chrisvanheuveln @jedelman8 @rahushen @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cisco Cisco technologies module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community owner_pr This PR is made by the module's maintainer. support:network This issue/PR relates to code supported by the Ansible Network Team. labels Apr 23, 2019
@trishnaguha trishnaguha self-assigned this Apr 24, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Apr 24, 2019
@ansibot ansibot added test This PR relates to tests. and removed owner_pr This PR is made by the module's maintainer. labels Apr 24, 2019
@mikewiebe mikewiebe changed the title [WIP] nxos_interface: Fix admin_state check for n6k nxos_interface: Fix admin_state check for n6k Apr 24, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. labels Apr 24, 2019
@mikewiebe
Copy link
Contributor Author

Please cherry-pick to stable2.8

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 4, 2019
@trishnaguha trishnaguha merged commit bceca72 into ansible:devel May 8, 2019
trishnaguha pushed a commit to trishnaguha/ansible that referenced this pull request May 8, 2019
@mikewiebe @trishnaguha
nxos_interface: Fix admin_state check for n6k (ansible#55673)
e255640 
* Fix admin_state check for n6k

* Fix rx and tx_rate intent check test

(cherry picked from commit bceca72)
abadger pushed a commit that referenced this pull request May 21, 2019
@mikewiebe @abadger
nxos_interface: Fix admin_state check for n6k (#55673)
79ec0ec 
* Fix admin_state check for n6k

* Fix rx and tx_rate intent check test

(cherry picked from commit bceca72)
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trishnaguha trishnaguha trishnaguha approved these changes

Assignees

@trishnaguha trishnaguha

Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mikewiebe @ansibot @trishnaguha