Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not native, but text #55676

Merged
merged 5 commits into from
May 24, 2019
Merged

Not native, but text #55676

merged 5 commits into from
May 24, 2019

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Apr 23, 2019

fix incorrect usages of to_native

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

all

@ansibot
Copy link
Contributor

ansibot commented Apr 23, 2019

cc @erjohnso @rambleraptor
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. inventory Inventory category needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 23, 2019
@rambleraptor
Copy link
Contributor

Looks fine on the gcp_compute plugin.

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_triage Needs a first human triage before being processed. core_review In order to be merged, this PR must follow the core review workflow. labels Apr 23, 2019
@mkrizek
Copy link
Contributor

mkrizek commented Apr 24, 2019

Just needs adding missing to_text imports and removing unused to_native ones.

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 26, 2019
@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels May 4, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 15, 2019
@bcoca bcoca merged commit 27dcf8a into ansible:devel May 24, 2019
@bcoca bcoca deleted the not_native branch May 24, 2019 18:49
bcoca added a commit to bcoca/ansible that referenced this pull request May 24, 2019
@bcoca
Not native, but text (ansible#55676)
375fdb5 
* use to_text instead of to_native
* cleaned up some imports and other pyflakisms
* fix missing lib messages

(cherry picked from commit 27dcf8a)
abadger pushed a commit that referenced this pull request Jun 3, 2019
@bcoca @abadger
Not native, but text (#55676) (#56935)
36580c4 
* Not native, but text (#55676)

* use to_text instead of to_native
* cleaned up some imports and other pyflakisms
* fix missing lib messages

(cherry picked from commit 27dcf8a)

* readded still used import
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sivel sivel sivel approved these changes

@mkrizek mkrizek mkrizek approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. inventory Inventory category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bcoca @ansibot @rambleraptor @mkrizek @sivel