XenServer: Minor changes and fixes in xenserver_guest #55678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- xenserver_guest module: ignore wait_for_ip_address when state=absent (fixes ansible#55348). Module docs are updated to reflect this. - xenserver_guest module: show proper error message when maximum number of network interfaces is reached and multiple network interfaces are added at once (fix for changes introduced in ansible#54697). - xenserver_guest module: fixed a bug in reconfigure() where VM would be powered off even though check mode is used when reconfiguration needs VM to be powered off.
ansibot
added
affects_2.9
ansibot
added
the
stale_ci
|
rebuild_merge |
ansibot
added
shipit
bvitnik
added a commit
to bvitnik/ansible
that referenced
this pull request
May 9, 2019
…55678) Backport of ansible#55678 to stable-2.8. * XenServer: Minor changes and fixes in xenserver_guest - xenserver_guest module: ignore wait_for_ip_address when state=absent (fixes ansible#55348). Module docs are updated to reflect this. - xenserver_guest module: show proper error message when maximum number of network interfaces is reached and multiple network interfaces are added at once (fix for changes introduced in ansible#54697). - xenserver_guest module: fixed a bug in reconfigure() where VM would be powered off even though check mode is used when reconfiguration needs VM to be powered off. * Added changelog fragment (cherry picked from commit 2a39dc8)
abadger
pushed a commit
that referenced
this pull request
May 21, 2019
Backport of #55678 to stable-2.8. * XenServer: Minor changes and fixes in xenserver_guest - xenserver_guest module: ignore wait_for_ip_address when state=absent (fixes #55348). Module docs are updated to reflect this. - xenserver_guest module: show proper error message when maximum number of network interfaces is reached and multiple network interfaces are added at once (fix for changes introduced in #54697). - xenserver_guest module: fixed a bug in reconfigure() where VM would be powered off even though check mode is used when reconfiguration needs VM to be powered off. * Added changelog fragment (cherry picked from commit 2a39dc8)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
state=absent (fixes XAPI ERRORs when force deleting vms in ansible with wait_for_ip_address set to yes #55348). Module docs are updated to reflect this.
of network interfaces is reached and multiple network interfaces are
added at once (fix for changes introduced in XenServer: Minor bug fixes 2 #54697).
be powered off even though check mode is used when reconfiguration
needs VM to be powered off.
SUMMARY
Minor changes in module behaviour and fixes for minor bugs.
ISSUE TYPE
COMPONENT NAME
xenserver_guest
ADDITIONAL INFORMATION
No additional info.