Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix firewalld source option handling to be exclusive #55715

Merged
merged 1 commit into from
May 1, 2019
Merged

Fix firewalld source option handling to be exclusive #55715

merged 1 commit into from
May 1, 2019

Conversation

saito-hideki
Copy link
Member

SUMMARY

Specifying the source option of the firewalld module should be exclusive as the same as the another option like interface, port or service etc.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • firewalld module
ADDITIONAL INFORMATION

None

@saito-hideki
Fix firewalld source option handling to be exclusive
ac91dcf 
- Fix issue #55683
- Add integration test for source option of firewalld module

Signed-off-by: Hideki Saito <saito@fgrep.org>
@saito-hideki saito-hideki changed the title [WIP] Fix firewalld source option handling to be exclusive Fix firewalld source option handling to be exclusive Apr 24, 2019
@ansibot
Copy link
Contributor

ansibot commented Apr 24, 2019

cc @maxamillion
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. system System category labels Apr 24, 2019
@maxamillion
Copy link
Contributor

rebuild_merge

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels May 1, 2019
@ansibot ansibot merged commit c455635 into ansible:devel May 1, 2019
ndclt pushed a commit to ndclt/ansible that referenced this pull request Jun 13, 2019
@saito-hideki @ndclt
Fix firewalld source option handling to be exclusive (ansible#55715)
de78795 
- Fix issue ansible#55683
- Add integration test for source option of firewalld module

Signed-off-by: Hideki Saito <saito@fgrep.org>
@ansible ansible locked and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. system System category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@saito-hideki @ansibot @maxamillion