mark entire module result untrusted as template #55717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.9
|
+1 Perhaps we should also add something to the documentation to say that executor doesn't trust action plugins to be written correctly and that action plugins must not trust the results from modules? If you agree, I can do that in a separate PR. |
|
@abadger yeah, that'd be fine- I think at least a statement of expectation in the developer guide or whatever would be a good thing (also gives us a chance to explain what that's all about) |
ansibot
added
shipit
ansibot
added
core_review
nitzmahone
removed
the
needs_triage
* prevents accidental templating on intra-action postprocessing of an untrusted module result * makes the view of a module result within an action consistent with the way it would be stored for future use (eg facts, register)
nitzmahone
added a commit
to nitzmahone/ansible
that referenced
this pull request
Apr 24, 2019
* prevents accidental templating on intra-action postprocessing of an untrusted module result * makes the view of a module result within an action consistent with the way it would be stored for future use (eg facts, register) (cherry picked from commit 03cac39)
abadger
pushed a commit
that referenced
this pull request
Apr 25, 2019
* prevents accidental templating on intra-action postprocessing of an untrusted module result * makes the view of a module result within an action consistent with the way it would be stored for future use (eg facts, register) (cherry picked from commit 03cac39)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
wrap_varcall to the very end ofActionBase._execute_module(), just in case anything else is added in the middle.ISSUE TYPE
COMPONENT NAME
ActionBase
ADDITIONAL INFORMATION