-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve testing of FactCache #55739
Merged
Merged
Improve testing of FactCache #55739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.9
This issue/PR affects Ansible v2.9
core_review
In order to be merged, this PR must follow the core review workflow.
feature
This issue/PR relates to a feature request.
needs_triage
Needs a first human triage before being processed.
python3
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
labels
Apr 24, 2019
ansibot
added
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
and removed
core_review
In order to be merged, this PR must follow the core review workflow.
labels
Apr 24, 2019
bcoca
removed
the
needs_triage
Needs a first human triage before being processed.
label
Apr 25, 2019
ansibot
added
the
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
label
May 8, 2019
The test
|
s-hertel
force-pushed
the
fact_cache-improve_testing
branch
from
June 10, 2019 19:28
80dca9b
to
aeff032
Compare
s-hertel
approved these changes
Jun 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 598a058
ansibot
added
core_review
In order to be merged, this PR must follow the core review workflow.
and removed
ci_verified
Changes made in this PR are causing tests to fail.
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
labels
Jun 10, 2019
agowa
pushed a commit
to agowa/ansible-1
that referenced
this pull request
Jun 30, 2019
* Improve testing of FactCache
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.9
This issue/PR affects Ansible v2.9
core_review
In order to be merged, this PR must follow the core review workflow.
feature
This issue/PR relates to a feature request.
python3
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
I think, I found a bug in the rewrite of FactCache (Commit bd7322a).
Added some tests to show the problem.
ISSUE TYPE
COMPONENT NAME
FactCache
ADDITIONAL INFORMATION
Legacy calls of FactCache.update() should be handled by FactCache.first_order_merge(), but the latter one is not defined.
My additional tests are showing this: