Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the get property for azure profile credential #55745

Merged
merged 1 commit into from Apr 26, 2019
Merged

Fix the get property for azure profile credential #55745

merged 1 commit into from Apr 26, 2019

Conversation

yuwzho
Copy link
Contributor

@yuwzho yuwzho commented Apr 25, 2019

SUMMARY

Ansible module has module_args with profile item with None value.
The dict.get(key, default) means default if key is not in dict, so the params.get('profile', 'default') always return None since profile is in params with None value.

"module_args": {
       ...
        "profile": null,
       ...
 }
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

azure_rm_common

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Apr 25, 2019

cc @haroldwongms @nitzmahone @trstringer @xscript @zikalino
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 azure bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Apr 25, 2019
@ansibleazurebot ansibleazurebot mentioned this pull request Apr 25, 2019
Closed
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Apr 25, 2019
@yuwzho yuwzho closed this Apr 25, 2019
@yuwzho yuwzho reopened this Apr 25, 2019
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 25, 2019
@zikalino zikalino merged commit c7bf3e0 into ansible:devel Apr 26, 2019
@zikalino zikalino deleted the yuwzho-common branch April 26, 2019 02:08
yuwzho added a commit to VSChina/ansible that referenced this pull request Apr 26, 2019
@yuwzho
Fix the get property (ansible#55745)
ab4a56f 
(cherry picked from commit c7bf3e0)
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Apr 30, 2019
abadger pushed a commit that referenced this pull request May 18, 2019
@yuwzho @abadger
Fix the get property (#55745) (#55788)
207fff7 
* Fix the get property (#55745)

(cherry picked from commit c7bf3e0)
amuraleedhar pushed a commit to amuraleedhar/ansible that referenced this pull request May 21, 2019
@yuwzho
Fix the get property (ansible#55745) (ansible#55788)
adf1505 
* Fix the get property (ansible#55745)

(cherry picked from commit c7bf3e0)
@ansible ansible locked and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 azure bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. owner_pr This PR is made by the module's maintainer. small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yuwzho @ansibot @sivel @zikalino