Skip tests with unsatisfied deps #55853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
\cc @mattclay |
ansibot
added
affects_2.9
|
@mattclay I'm not quite sure why the cloudstack test is failing now.... The pytestmark to skip the test on python-2.6 is functioning correctly locally. I can change it to skip the test if it's on python-2.6 in a different way (it was using unittest before).... I'm just not sure why this syntax is failing in our setup. |
abadger
force-pushed
the
skip-tests-with-unsatisfied-deps
branch
5 times, most recently
from
e342ee2
to
901ce52
Compare
|
@mattclay, I figured out what my mistake was. The test was failing when it tested whether it could import the cs module. The toplevel code in the test all runs and registers whether any of the conditions would cause it to skip. Since I was trying to import Should work now! 🤞 |
ansibot
added
core_review
|
ready_for_review :-) |
samdoran
removed
the
needs_triage
ansibot
added
the
stale_ci
mattclay
approved these changes
May 14, 2019
ansibot
added
needs_rebase
If either on Python-2.6 or the cs library is not installed we cannot run this test so skip it
abadger
force-pushed
the
skip-tests-with-unsatisfied-deps
branch
from
901ce52
to
9d6266f
Compare
ansibot
added
core_review
abadger
added a commit
to abadger/ansible
that referenced
this pull request
Jun 29, 2019
* Skip gitlab tests if dependencies aren't met * Skip certain unittests if passlib is not installed * Fix tests with deps on paramiko to skip if paramiko is not installed * Use pytest to skip for cloudstack If either on Python-2.6 or the cs library is not installed we cannot run this test so skip it (cherry picked from commit 8acf71f) Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
abadger
added a commit
that referenced
this pull request
Jun 29, 2019
* Skip gitlab tests if dependencies aren't met * Skip certain unittests if passlib is not installed * Fix tests with deps on paramiko to skip if paramiko is not installed * Use pytest to skip for cloudstack If either on Python-2.6 or the cs library is not installed we cannot run this test so skip it (cherry picked from commit 8acf71f) Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
agowa
pushed a commit
to agowa/ansible-1
that referenced
this pull request
Jun 30, 2019
* Skip gitlab tests if dependencies aren't met * Skip certain unittests if passlib is not installed * Fix tests with deps on paramiko to skip if paramiko is not installed * Use pytest to skip for cloudstack If either on Python-2.6 or the cs library is not installed we cannot run this test so skip it
abadger
added a commit
to abadger/ansible
that referenced
this pull request
Jul 1, 2019
* Skip gitlab tests if dependencies aren't met * Skip certain unittests if passlib is not installed * Fix tests with deps on paramiko to skip if paramiko is not installed * Use pytest to skip for cloudstack If either on Python-2.6 or the cs library is not installed we cannot run this test so skip it. (cherry picked from commit 8acf71f) Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
abadger
added a commit
that referenced
this pull request
Jul 1, 2019
* Skip gitlab tests if dependencies aren't met * Skip certain unittests if passlib is not installed * Fix tests with deps on paramiko to skip if paramiko is not installed * Use pytest to skip for cloudstack If either on Python-2.6 or the cs library is not installed we cannot run this test so skip it. (cherry picked from commit 8acf71f) Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
abadger
added a commit
to abadger/ansible
that referenced
this pull request
Jul 1, 2019
…5853) * Skip gitlab tests if dependencies aren't met * Skip certain unittests if passlib is not installed * Fix tests with deps on paramiko to skip if paramiko is not installed * Use pytest to skip for cloudstack If either on Python-2.6 or the cs library is not installed we cannot run this test so skip it. (cherry picked from commit 8acf71f) Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>. (cherry picked from commit 7d4e9b2) Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Tests for modules or other plugins whose deps fall outside of ansible's core dependency set need to check whether the deps are installed and skip if they are not.
This PR skips for several tests which were found to be running even when their deps were not installed.
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
backport to 2.8 when merged.