Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reboot/win_reboot - Clarify documentation about delay parameters #55934

Merged
merged 1 commit into from Apr 30, 2019
Merged

reboot/win_reboot - Clarify documentation about delay parameters #55934

merged 1 commit into from Apr 30, 2019

Conversation

samdoran
Copy link
Contributor

SUMMARY

There was some confusion about how pre_reboot_delay, post_reboot_delay, and connect_timeout are used during the reboot process. Update the documentation to clarify their behavior.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

lib/ansible/modules/system/reboot.py
lib/ansible/modules/windows/win_reboot.py

@samdoran
Copy link
Contributor Author

cc @mrmibrown

@ansibot
Copy link
Contributor

ansibot commented Apr 30, 2019

cc @dagwieers @if-meaton @jborean93 @jhawkesworth @nitzmahone
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:core This issue/PR relates to code supported by the Ansible Engineering Team. system System category windows Windows community labels Apr 30, 2019
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Apr 30, 2019
@acozine acozine merged commit 0e8a6e0 into ansible:devel Apr 30, 2019
samdoran added a commit to samdoran/ansible that referenced this pull request Apr 30, 2019
@samdoran
[stable-2.8] Clarify documentation an reboot delay paramaters (ansibl…
a640ecd 
…e#55934)

(cherry picked from commit 0e8a6e0)

Co-authored-by: Sam Doran <sdoran@redhat.com>
@samdoran samdoran mentioned this pull request Apr 30, 2019
Merged
samdoran added a commit to samdoran/ansible that referenced this pull request Apr 30, 2019
@samdoran
[stable-2.7] Clarify documentation an reboot delay paramaters (ansibl…
551bcfa 
…e#55934).

(cherry picked from commit 0e8a6e0)

Co-authored-by: Sam Doran <sdoran@redhat.com>
@samdoran samdoran mentioned this pull request Apr 30, 2019
Merged
abadger pushed a commit that referenced this pull request May 1, 2019
@samdoran @abadger
[stable-2.8] Clarify documentation an reboot delay paramaters (#55934)
f03d9c1 
(cherry picked from commit 0e8a6e0)

Co-authored-by: Sam Doran <sdoran@redhat.com>
acozine pushed a commit that referenced this pull request May 6, 2019
@samdoran @acozine
[stable-2.7] Clarify documentation an reboot delay paramaters (#55934)…
ac416f0 
…. (#55959)

(cherry picked from commit 0e8a6e0)

Co-authored-by: Sam Doran <sdoran@redhat.com>
@ansible ansible locked and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. support:core This issue/PR relates to code supported by the Ansible Engineering Team. system System category windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samdoran @ansibot @acozine