Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes for GCP (as of 2019-05-01T06:04:57Z) #55976

Merged
merged 1 commit into from
May 28, 2019
Merged

Bug fixes for GCP (as of 2019-05-01T06:04:57Z) #55976

merged 1 commit into from
May 28, 2019

Conversation

modular-magician
Copy link
Contributor

SUMMARY

Bug fixes for GCP (as of 2019-05-01T06:04:57Z)

ISSUE TYPE
  • Bugfix Pull Request
ADDITIONAL INFORMATION
This was generated by [Magic Modules](https://github.com/googlecloudplatform/magic-modules)

@ansibot
Copy link
Contributor

ansibot commented May 1, 2019

cc @erjohnso @GoogleCloudPlatform @rambleraptor
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. gce module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels May 1, 2019
@modular-magician modular-magician force-pushed the bug_fixesmm-bugad branch 3 times, most recently from 6069ed3 to 8b8ebcb Compare May 4, 2019 06:06
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels May 4, 2019
@modular-magician modular-magician force-pushed the bug_fixesmm-bugad branch 8 times, most recently from 0e954be to 6891e00 Compare May 12, 2019 06:04
@modular-magician modular-magician force-pushed the bug_fixesmm-bugad branch 7 times, most recently from b872ea1 to 5e4ebe2 Compare May 19, 2019 06:05
@modular-magician modular-magician force-pushed the bug_fixesmm-bugad branch 2 times, most recently from af31cc9 to 72f5a13 Compare May 21, 2019 06:06
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 21, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels May 22, 2019
@ansibot
Copy link
Contributor

ansibot commented May 23, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 8 errors:

lib/ansible/modules/cloud/google/gcp_container_cluster.py:0:0: E326 Argument 'logging_service' in argument_spec defines choices as ([]) but documentation defines choices as (['logging.googleapis.com', 'none'])
lib/ansible/modules/cloud/google/gcp_container_cluster.py:0:0: E326 Argument 'monitoring_service' in argument_spec defines choices as ([]) but documentation defines choices as (['monitoring.googleapis.com', 'none'])
lib/ansible/modules/cloud/google/gcp_dns_managed_zone.py:0:0: E326 Argument 'visibility' in argument_spec defines choices as ([]) but documentation defines choices as (['private', 'public'])
lib/ansible/modules/cloud/google/gcp_dns_resource_record_set.py:0:0: E326 Argument 'type' in argument_spec defines choices as ([]) but documentation defines choices as (['A', 'AAAA', 'CAA', 'CNAME', 'MX', 'NAPTR', 'NS', 'PTR', 'SOA', 'SPF', 'SRV', 'TLSA', 'TXT'])
lib/ansible/modules/cloud/google/gcp_iam_role.py:0:0: E326 Argument 'stage' in argument_spec defines choices as ([]) but documentation defines choices as (['ALPHA', 'BETA', 'GA', 'DEPRECATED', 'DISABLED', 'EAP'])
lib/ansible/modules/cloud/google/gcp_iam_service_account_key.py:0:0: E326 Argument 'key_algorithm' in argument_spec defines choices as ([]) but documentation defines choices as (['KEY_ALG_UNSPECIFIED', 'KEY_ALG_RSA_1024', 'KEY_ALG_RSA_2048'])
lib/ansible/modules/cloud/google/gcp_iam_service_account_key.py:0:0: E326 Argument 'private_key_type' in argument_spec defines choices as ([]) but documentation defines choices as (['TYPE_UNSPECIFIED', 'TYPE_PKCS12_FILE', 'TYPE_GOOGLE_CREDENTIALS_FILE'])
lib/ansible/modules/cloud/google/gcp_redis_instance.py:0:0: E326 Argument 'tier' in argument_spec defines choices as ([]) but documentation defines choices as (['BASIC', 'STANDARD_HA'])

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label May 23, 2019
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 24, 2019
@modular-magician modular-magician force-pushed the bug_fixesmm-bugad branch 3 times, most recently from cf541cc to 47339a0 Compare May 27, 2019 06:06
@rambleraptor
Copy link
Contributor

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels May 28, 2019
@ansibot ansibot merged commit a837cc5 into ansible:devel May 28, 2019
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. cloud gce module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@modular-magician @ansibot @rambleraptor