Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix documentation for docker_container publish_ports option #56093

Merged
merged 1 commit into from May 5, 2019
Merged

fix documentation for docker_container publish_ports option #56093

merged 1 commit into from May 5, 2019
+0 −1

Conversation

larsks
Copy link
Contributor

@larsks larsks commented May 5, 2019

SUMMARY

The documentation for the docker_container publish_ports options
erroneously stated that container ports must be "exposed" in order to
be "published".

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

docker_container

@larsks
fix documentation for docker_container publish_ports option
bca5f3a 
The documentation for the docker_container publish_ports options
erroneously stated that container ports must be "exposed" in order to
be "published".
@ansibot
Copy link
Contributor

ansibot commented May 5, 2019

cc @DBendit @WojciechowskiPiotr @akshay196 @chouseknecht @cove @danihodovic @dariko @dusdanig @felixfontein @joshuaconner @jwitko @kassiansun @softzilla @tbouvet @zfil
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 cloud community_review In order to be merged, this PR must follow the community review workflow. docker docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels May 5, 2019
felixfontein
felixfontein approved these changes May 5, 2019
View reviewed changes
Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels May 5, 2019
@ansibot ansibot merged commit 5e74ecb into ansible:devel May 5, 2019
felixfontein pushed a commit to felixfontein/ansible that referenced this pull request May 5, 2019
@larsks @felixfontein
fix documentation for docker_container publish_ports option (ansible#…
5ba0a4e 
…56093)

The documentation for the docker_container publish_ports options
erroneously stated that container ports must be "exposed" in order to
be "published".

(cherry picked from commit 5e74ecb)
felixfontein pushed a commit to felixfontein/ansible that referenced this pull request May 5, 2019
@larsks @felixfontein
fix documentation for docker_container publish_ports option (ansible#…
fc5b098 
…56093)

The documentation for the docker_container publish_ports options
erroneously stated that container ports must be "exposed" in order to
be "published".

(cherry picked from commit 5e74ecb)
This was referenced May 5, 2019
Merged
Merged
acozine pushed a commit that referenced this pull request May 6, 2019
@felixfontein @acozine
fix documentation for docker_container publish_ports option (#56093) (#…
0829325 
…56100)

The documentation for the docker_container publish_ports options
erroneously stated that container ports must be "exposed" in order to
be "published".

(cherry picked from commit 5e74ecb)
acozine pushed a commit that referenced this pull request May 6, 2019
@felixfontein @acozine
fix documentation for docker_container publish_ports option (#56093) (#…
954462c 
…56099)

The documentation for the docker_container publish_ports options
erroneously stated that container ports must be "exposed" in order to
be "published".

(cherry picked from commit 5e74ecb)
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 automerge This PR was automatically merged by ansibot. cloud docker docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. shipit This PR is ready to be merged by Core small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@larsks @ansibot @felixfontein