Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hetzner failover IP module #56103

Merged
merged 6 commits into from
May 7, 2019
Merged

Conversation

felixfontein
Copy link
Contributor

SUMMARY

This module allows to configure Failover IPs with the german hosting provider Hetzner. Failover IPs route all traffic to them to a destination IP, which can be changed on the fly (they can also be set to unrouted).

Failover IPs are a feature for dedicated and virtual servers, and unrelated to hcloud. I've put it into modules/net_tools because of that. Uses the Robot API described here.

The module supports check mode and diff support; so far, I only tested routing failover IPs and not unrouting them, since I only have access to failover IPs used in production.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

hetzner_failover_ip

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. net_tools Net-tools category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels May 5, 2019
@resmo
Copy link
Contributor

resmo commented May 6, 2019

/cc @LKaemmerling

Copy link
Contributor

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. labels May 6, 2019
@LKaemmerling
Copy link
Contributor

shipit

@resmo resmo merged commit ba9fee6 into ansible:devel May 7, 2019
@felixfontein felixfontein deleted the hetzner-failoverip branch May 7, 2019 17:42
@felixfontein
Copy link
Contributor Author

@resmo @LKaemmerling thanks a lot for reviewing this!

My next step will be adding a hetzner_failover_ip_info module, and moving some common code into module_utils.

ndclt pushed a commit to ndclt/ansible that referenced this pull request Jun 13, 2019
* First version of Hetzner failover IP module.

* Extend module.

* Add comments.

* Add basic unit tests.

* Add more tests.

* Tests for set_failover.
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.9 This issue/PR affects Ansible v2.9 module This issue/PR relates to a module. net_tools Net-tools category new_module This PR includes a new module. new_plugin This PR includes a new plugin. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants