Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't fail trying to read boot image wihtout enable #56126

Merged
merged 2 commits into from May 6, 2019
Merged

Don't fail trying to read boot image wihtout enable #56126

merged 2 commits into from May 6, 2019

Conversation

Qalthos
Copy link
Contributor

@Qalthos Qalthos commented May 6, 2019

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

cliconf/eos

Qalthos
Qalthos commented May 6, 2019
View reviewed changes
lib/ansible/plugins/cliconf/eos.py
if match:
device_info['network_os_image'] = match.group(1)
try:
reply = self.get('bash timeout 5 cat /mnt/flash/boot-config')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific reason we do this instead of show boot-config | json?

@Qalthos Qalthos requested a review from trishnaguha May 6, 2019 16:17
@ansibot
Copy link
Contributor

ansibot commented May 6, 2019

cc @NilashishC @ganeshrn @gdpak @justjais @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. networking Network category support:network This issue/PR relates to code supported by the Ansible Network Team. labels May 6, 2019
@pabelanger pabelanger mentioned this pull request May 6, 2019
Merged
pabelanger added a commit to pabelanger/ansible-zuul-jobs-1 that referenced this pull request May 6, 2019
@pabelanger
Add ansible-test-network-integration-eos job
75114ee 
This now adds support to run eos tests against ansible/ansible.

Depends-On: ansible/ansible#56126
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
@pabelanger
Copy link
Contributor

pabelanger commented May 6, 2019 •
edited

This was pre-merged tested on zuul.ansible.com and appears to fix the issue:

https://logs.zuul.ansible.com/48/48/75114ee6342481028f1bda3ab449e339dba00a42/check/ansible-test-network-integration-eos-devel/ace067e/job-output.txt

ganeshrn
ganeshrn reviewed May 6, 2019
View reviewed changes
lib/ansible/plugins/cliconf/eos.py
if match:
device_info['network_os_image'] = match.group(1)
except AnsibleConnectionFailure:
# This requires enable mode to run
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we emit a warning/info instead of silently failing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a warning might be a bit strong for this, but I don't know what the implications of this data not being populated are.

pabelanger added a commit to pabelanger/ansible-zuul-jobs-1 that referenced this pull request May 6, 2019
@pabelanger
Add ansible-test-network-integration-eos job
835f745 
This now adds support to run eos tests against ansible/ansible.

Depends-On: ansible/ansible#56126
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label May 6, 2019
pabelanger added a commit to pabelanger/ansible-zuul-jobs-1 that referenced this pull request May 6, 2019
@pabelanger
Add ansible-test-network-integration-eos job
a50b54d 
This now adds support to run eos tests against ansible/ansible.

Depends-On: ansible/ansible#56126
Depends-On: ansible/ansible#56131
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
pabelanger added a commit to pabelanger/ansible-zuul-jobs-1 that referenced this pull request May 6, 2019
@pabelanger
Add ansible-test-network-integration-eos job
37d7c0c 
This now adds support to run eos tests against ansible/ansible.

Depends-On: ansible/ansible#56126
Depends-On: ansible/ansible#56131
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
@Qalthos Qalthos merged commit 3d9da0c into ansible:devel May 6, 2019
@Qalthos Qalthos deleted the eos_bash_when_disabled branch May 6, 2019 19:17
pabelanger added a commit to pabelanger/ansible-zuul-jobs-1 that referenced this pull request May 6, 2019
@pabelanger
Add ansible-test-network-integration-eos job
cb84444 
This now adds support to run eos tests against ansible/ansible.

Depends-On: ansible/ansible#56126
Depends-On: ansible/ansible#56131
Depends-On: ansible/ansible#56136
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
pabelanger added a commit to pabelanger/ansible-zuul-jobs-1 that referenced this pull request May 6, 2019
@pabelanger
Add ansible-test-network-integration-eos job
2be8284 
This now adds support to run eos tests against ansible/ansible.

Depends-On: ansible/ansible#56126
Depends-On: ansible/ansible#56131
Depends-On: ansible/ansible#56136
Depends-On: ansible/ansible#56140
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
pabelanger added a commit to pabelanger/ansible-zuul-jobs-1 that referenced this pull request May 7, 2019
@pabelanger
Add ansible-test-network-integration-eos job
583c9a0 
This now adds support to run eos tests against ansible/ansible.

Depends-On: ansible/ansible#56126
Depends-On: ansible/ansible#56131
Depends-On: ansible/ansible#56136
Depends-On: ansible/ansible#56140
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
pabelanger added a commit to pabelanger/ansible-zuul-jobs-1 that referenced this pull request May 7, 2019
@pabelanger
Add ansible-test-network-integration-eos job
02447fc 
This now adds support to run eos tests against ansible/ansible.

Depends-On: ansible/ansible#56126
Depends-On: ansible/ansible#56131
Depends-On: ansible/ansible#56136
Depends-On: ansible/ansible#56140
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
pabelanger added a commit to pabelanger/ansible-zuul-jobs-1 that referenced this pull request May 7, 2019
@pabelanger
Add ansible-test-network-integration-eos job
245503a 
This now adds support to run eos tests against ansible/ansible.

Depends-On: ansible/ansible#56126
Depends-On: ansible/ansible#56131
Depends-On: ansible/ansible#56136
Depends-On: ansible/ansible#56140
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
pabelanger added a commit to pabelanger/ansible-zuul-jobs-1 that referenced this pull request May 7, 2019
@pabelanger
Add ansible-test-network-integration-eos job
21420d4 
This now adds support to run eos tests against ansible/ansible.

Depends-On: ansible/ansible#56126
Depends-On: ansible/ansible#56131
Depends-On: ansible/ansible#56136
Depends-On: ansible/ansible#56140
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
pabelanger added a commit to pabelanger/ansible-zuul-jobs-1 that referenced this pull request May 7, 2019
@pabelanger
Add ansible-test-network-integration-eos job
4bdd175 
This now adds support to run eos tests against ansible/ansible.

Depends-On: ansible/ansible#56126
Depends-On: ansible/ansible#56131
Depends-On: ansible/ansible#56136
Depends-On: ansible/ansible#56140
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Qalthos added a commit to Qalthos/ansible that referenced this pull request May 14, 2019
@Qalthos
[stable-2.8] Don't fail trying to read boot image without enable (ans…
ad85bf9 
…ible#56126)

Also add a message when network_os_image can't be acquired.
(cherry picked from commit 3d9da0c)

Co-authored-by: Nathaniel Case <ncase@redhat.com>
abadger pushed a commit that referenced this pull request May 24, 2019
@Qalthos @abadger
[stable-2.8] Don't fail trying to read boot image without enable (#56126
92e4a98 
) (#56134)

* [stable-2.8] Don't fail trying to read boot image without enable (#56126)

Also add a message when network_os_image can't be acquired.
(cherry picked from commit 3d9da0c)

Co-authored-by: Nathaniel Case <ncase@redhat.com>

* Add changelog

* Fix changelog
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ganeshrn ganeshrn ganeshrn approved these changes

@trishnaguha trishnaguha Awaiting requested review from trishnaguha

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. networking Network category support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Qalthos @ansibot @pabelanger @ganeshrn