-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
k8s: Fix .to_dict not needed #56147
k8s: Fix .to_dict not needed #56147
Conversation
Provide wait and wait_timeout parameters and wait for certain resource kinds to become available.
There should be a test case for this under test/integration/targets/k8s - could you add one please? I'm not 100% convinced this is correct in all cases (e.g. when |
Yes, I'll work on this. One question.
But there is no "runme.sh" in this particular folder.
This is what was happening for me. I don't have "wait" set and it was raising an exception. I checked and "k8s_obj" is a dict when not set.
I'll try to add a test on the existing code to reproduce the problem I was having. |
Yeah, that's a little out of date (I wrote the original README and then runme.sh got removed by someone else). I think
might do the trick but not 100% sure - I'll take a look later if not. |
The tests really aren't working very well at the moment, I'm disappointed that the result of the refactor wasn't properly tested. I'll have a PR up for that shortly which will be a better basis for the tests needed for this PR |
I had to create #56163 for In the mean time I've been using the following playbook:
|
I believe we may be running into this in some circumstances even when we are not using
|
@geerlingguy if you're hitting it without That said, I might have fixed your issue with #56168 |
@jfrabaute let me know if you have any difficulties with that test case |
Rebased and added a changelog fragment so we can backport this to 2.8 - I do have a working test for this but I'll raise that separately so that the backport doesn't need to include the test suite changes |
Thanks @jfrabaute! |
* k8s: Fix .to_dict not needed * Add changelog fragment (cherry picked from commit 7364e79)
Tests are separate for easier backporting
Sorry, I haven't taken the time to work on the test after sending the PR. |
* k8s: Fix .to_dict not needed * Add changelog fragment (cherry picked from commit 7364e79)
Tests are separate for easier backporting
Tests are separate for easier backporting
SUMMARY
Fixes small bug in k8s module
ISSUE TYPE
COMPONENT NAME
k8s
ADDITIONAL INFORMATION
Trying to deploy a simple ConfigMap with the "k8s" module and "force" set to true should reproduce the error.