Don't rely on netloc for determining hostname and port, just use hostname and port #56270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.9
jillr
removed
the
needs_triage
samdoran
suggested changes
May 20, 2019
There was a problem hiding this comment.
Tested and this change is good. Hooray for deleting code.
Please add unit tests to test/units/module_utils/urls/test_urls.py:78
url = 'https://[2a00:16d8:0:7::205]:4443/'
handler = urls.maybe_add_ssl_handler(url, True)
assert handler.hostname == '2a00:16d8:0:7::205'
assert handler.port == 4443
url = 'https://[2a00:16d8:0:7::205]/'
handler = urls.maybe_add_ssl_handler(url, True)
assert handler.hostname == '2a00:16d8:0:7::205'
assert handler.port == 443Maybe add integration tests as well.
ansibot
added
needs_revision
ansibot
removed
the
stale_ci
samdoran
reviewed
May 20, 2019
|
I've added unit tests, and resolved some Python2.6 issues that were causing tracebacks. Integration tests aren't possible at this time, since the httptester container and intra-contatiner communications isn't IPv6 enabled. |
samdoran
approved these changes
May 20, 2019
sivel
added a commit
to sivel/ansible
that referenced
this pull request
May 21, 2019
…just use hostname and port (ansible#56270) * Add changelog fragment * Fix IPv6 address parsing for py2.6, and add tests * make sure hostname isn't None (cherry picked from commit 493cf81) Co-authored-by: Matt Martz <matt@sivel.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Don't rely on netloc for determining hostname and port, just use hostname and port. Fixes #56258
This resolves a bug when handling redirects with IPv6 addresses in the URL.
ISSUE TYPE
COMPONENT NAME
lib/ansible/module_utils/urls.py
ADDITIONAL INFORMATION