Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some logging fixes #56311

Merged
merged 5 commits into from
May 24, 2019
Merged

some logging fixes #56311

merged 5 commits into from
May 24, 2019

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented May 10, 2019

fixes #25757, #25758, #25761
alternative to #41859 and #25765

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

display

before:

2019-05-10 12:52:31,375 p=27869 u=bcoca |   [WARNING]: No inventory was parsed, only implicit localhost is available

2019-05-10 12:52:31,537 passlib.registry registered 'md5_crypt' handler: <class 'passlib.handlers.md5_crypt.md5_crypt'>
2019-05-10 12:52:31,774 p=27869 u=bcoca |  localhost | SUCCESS => {
    "changed": false,
    "ping": "pong"
}

after:

2019-05-10 12:49:01,788 p=bcoca u=26808 |  [WARNING]: No inventory was parsed, only implicit localhost is available

2019-05-10 12:49:02,176 p=bcoca u=26808 | localhost | SUCCESS => {
    "changed": false,
    "ping": "pong"
}

not sure it is worth passing levels if they are not reflected in file (well, we do error/warning/deprecation ..)

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels May 10, 2019
lib/ansible/utils/display.py Outdated Show resolved Hide resolved
@jillr jillr removed the needs_triage Needs a first human triage before being processed. label May 16, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 22, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 23, 2019
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Logger() setup by utils.display uses an unconventional name
6 participants