-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
some logging fixes #56311
Merged
Merged
some logging fixes #56311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes ansible#25757, ansible#25758, ansible#25761 alternative to ansible#41859 and ansible#25765
ansibot
added
affects_2.9
This issue/PR affects Ansible v2.9
bug
This issue/PR relates to a bug.
core_review
In order to be merged, this PR must follow the core review workflow.
needs_triage
Needs a first human triage before being processed.
support:community
This issue/PR relates to code supported by the Ansible community.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
labels
May 10, 2019
sivel
reviewed
May 10, 2019
samdoran
reviewed
May 10, 2019
mkrizek
reviewed
May 13, 2019
jillr
removed
the
needs_triage
Needs a first human triage before being processed.
label
May 16, 2019
ansibot
added
the
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
label
May 22, 2019
ansibot
added
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
core_review
In order to be merged, this PR must follow the core review workflow.
and removed
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
core_review
In order to be merged, this PR must follow the core review workflow.
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
labels
May 23, 2019
samdoran
approved these changes
May 24, 2019
mkrizek
reviewed
May 24, 2019
mkrizek
approved these changes
May 24, 2019
This was referenced May 24, 2019
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.9
This issue/PR affects Ansible v2.9
bug
This issue/PR relates to a bug.
core_review
In order to be merged, this PR must follow the core review workflow.
support:community
This issue/PR relates to code supported by the Ansible community.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #25757, #25758, #25761
alternative to #41859 and #25765
ISSUE TYPE
COMPONENT NAME
display
before:
after:
not sure it is worth passing levels if they are not reflected in file (well, we do error/warning/deprecation ..)