Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport PR for fixing NIOS_ZONE module idempotency #56346

Merged
merged 4 commits into from
May 21, 2019
Merged

Backport PR for fixing NIOS_ZONE module idempotency #56346

merged 4 commits into from
May 21, 2019

Conversation

justjais
Copy link
Contributor

SUMMARY

Cherrypicked from commit (661f7be)
Backport for PR #55595
Backport PR for fixing NIOS_ZONE module idempotency, raised in issue #55128,

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@justjais
To fix the issue where nios_zone module was running second time for s…
d5333c3 
…ame object (ansible#55595)

* fix for 55128 issue

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* review comment fix

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
(cherry picked from commit 661f7be)
@justjais
changelog for 2.7 backport
fd8d51f 
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@justjais
changelog for 2.7 backport
3e98564 
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@ansibot
Copy link
Contributor

ansibot commented May 13, 2019

cc @NilashishC @Qalthos @ganeshrn @gdpak @rcarrillocruz @sganesh-infoblox @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. infoblox Infoblox NIOS needs_triage Needs a first human triage before being processed. net_tools Net-tools category networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels May 13, 2019
@justjais
shippable fix
6511caf 
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. labels May 13, 2019
@abadger abadger merged commit 85b21c2 into ansible:stable-2.7 May 21, 2019
@abadger
Copy link
Contributor

abadger commented May 21, 2019

Merged for the 2.7.11 release

@sivel sivel removed the needs_triage Needs a first human triage before being processed. label May 22, 2019
@justjais justjais deleted the backport/2.7/55595 branch June 4, 2019 10:36
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. infoblox Infoblox NIOS net_tools Net-tools category networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@justjais @ansibot @abadger @sivel