Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix VyOS cli prompt issues #56389

Merged
merged 1 commit into from May 14, 2019
Merged

Fix VyOS cli prompt issues #56389

merged 1 commit into from May 14, 2019

Conversation

NilashishC
Copy link
Contributor

Signed-off-by: NilashishC nilashishchakraborty8@gmail.com

SUMMARY
---
- name: Remove Config
  cli_config:
    config: "{{ lines }}"
  vars:
    lines: |
      delete interfaces ethernet "{{ intf }}" description
      delete interfaces ethernet "{{ intf }}" speed
      delete interfaces ethernet "{{ intf }}" duplex
      delete interfaces ethernet "{{ intf }}" mtu
      delete interfaces ethernet "{{ intf }}" disable
      delete interfaces ethernet "{{ intf }}" vif
  loop:
    - eth1
    - eth2
    - eth3
  loop_control:
    loop_var: intf
  • This PR adds the patch in cliconf/edit_config too.
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

cliconf/vyos.py

@NilashishC NilashishC requested a review from ganeshrn May 14, 2019 09:41
@ansibot
Copy link
Contributor

ansibot commented May 14, 2019

cc @Qalthos @ganeshrn @gdpak @justjais @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. networking Network category small_patch support:network This issue/PR relates to code supported by the Ansible Network Team. labels May 14, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels May 14, 2019
@NilashishC
Fix VyOS cli prompt issues
5ebe613 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 14, 2019
ganeshrn
ganeshrn approved these changes May 14, 2019
View reviewed changes
Copy link
Member

@ganeshrn ganeshrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@NilashishC NilashishC merged commit 30ccc8e into ansible:devel May 14, 2019
@NilashishC NilashishC deleted the fix_vyos_prompt branch May 14, 2019 13:47
NilashishC added a commit to NilashishC/ansible that referenced this pull request May 14, 2019
@NilashishC
Fix VyOS cli prompt issues (ansible#56389)
ac6b6b7 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
(cherry picked from commit 30ccc8e)

Add changelog for vyos prompt issue fix
@NilashishC NilashishC mentioned this pull request May 14, 2019
Merged
NilashishC added a commit to NilashishC/ansible that referenced this pull request May 14, 2019
@NilashishC
Fix VyOS cli prompt issues (ansible#56389)
3e0d899 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
(cherry picked from commit 30ccc8e)

Add changelog for vyos prompt fix
@NilashishC NilashishC mentioned this pull request May 14, 2019
Merged
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label May 14, 2019
abadger pushed a commit that referenced this pull request May 21, 2019
@NilashishC @abadger
Fix VyOS cli prompt issues (#56389)
aa616b4 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
(cherry picked from commit 30ccc8e)

Add changelog for vyos prompt fix
abadger pushed a commit that referenced this pull request May 21, 2019
@NilashishC @abadger
Fix VyOS cli prompt issues (#56389)
0586534 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
(cherry picked from commit 30ccc8e)

Add changelog for vyos prompt issue fix
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ganeshrn ganeshrn ganeshrn approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. networking Network category small_patch support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NilashishC @ansibot @ganeshrn @sivel