Win_hostname module: Change name check to WMI #56420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @dagwieers @if-meaton @jborean93 @jhawkesworth @nitzmahone |
ansibot
added
affects_2.9
jhawkesworth
changed the title
ansibot
removed
the
new_contributor
samdoran
removed
the
needs_triage
jborean93
requested changes
May 28, 2019
changelogs/fragments/56420-Fix-win_hostname-for-non-netbios-names.yml
Outdated
Show resolved
Hide resolved
ansibot
added
needs_revision
ansibot
removed
the
stale_ci
jborean93
approved these changes
May 28, 2019
|
This is a good candidate for backporting to stable-2.8. |
So simply create a new PR of this into the said branch? |
|
Have a look at https://docs.ansible.com/ansible/latest/community/development_process.html#backporting-merged-prs. It involves "cherry-picking" the commit to the older stable-2.x branch then creating a PR with that. |
Merged
abadger
pushed a commit
that referenced
this pull request
May 29, 2019
* Change name check to WMI * Changelog fragment * Fixed per review (cherry picked from commit 94566ed)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fix non netbios compliant name handling - #55283
ISSUE TYPE
COMPONENT NAME
win_hostname.ps1
ADDITIONAL INFORMATION