Preserve ssh error

[bcoca]

Allow original ssh error to be seen and traceback to be available on high verbosity
fixes #35313

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

connection/ssh

[bcoca]

cc @JulienPalard @kustodian @paulRbr

[JulienPalard]

Hi Brian! Thanks for looking at it!

I tested your PR locally and it does not fix my personal issue, so I propose also changing:

diff --git a/lib/ansible/plugins/connection/ssh.py b/lib/ansible/plugins/connection/ssh.py
index 23a365f9db..36f76d57b7 100644
--- a/lib/ansible/plugins/connection/ssh.py
+++ b/lib/ansible/plugins/connection/ssh.py
@@ -1034,7 +1034,7 @@ class Connection(ConnectionBase):
             raise AnsibleControlPersistBrokenPipeError('SSH Error: data could not be sent because of ControlPersist broken pipe.')
 
         if p.returncode == 255 and in_data and checkrc:
-            raise AnsibleConnectionFailure('SSH Error: data could not be sent to remote host "%s". Make sure this host can be reached over ssh' % self.host)
+            raise AnsibleConnectionFailure('Data could not be sent to remote host "%s". Make sure this host can be reached over ssh: %s' % (self.host, to_native(b_stderr)))
 
         return (p.returncode, b_stdout, b_stderr)
 

without my change on your branch I'm getting:

TASK [Gathering Facts] ****************************************************************************************************************************
fatal: [staging.example.com]: UNREACHABLE! => {"changed": false, "msg": "SSH Error: data could not be sent to remote host \"red.act.ed.ip\". Make sure this host can be reached over ssh", "unreachable": true}

with my change:

TASK [Gathering Facts] ****************************************************************************************************************************
fatal: [staging.example.com]: UNREACHABLE! => {"changed": false, "msg": "Data could not be sent to remote host \"red.act.ed.ip\". Make sure this host can be reached over ssh: sign_and_send_pubkey: signing failed: agent refused operation\r\nroot@red.act.ed.ip: Permission denied (publickey,password).\r\n", "unreachable": true}

[JulienPalard]

LGTM, I'm getting:

TASK [Gathering Facts] ****************************************************************************************************************************
fatal: [staging1.example.com]: UNREACHABLE! => {"changed": false, "msg": "Data could not be sent to remote host \"re.dac.ted.ip\". Make sure this host can be reached over ssh: sign_and_send_pubkey: signing failed: agent refused operation\r\nroot@re.dac.ted.ip: Permission denied (publickey,password).\r\n", "unreachable": true}