Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gcp_compute_instance_facts.py #56581

Merged
merged 1 commit into from May 20, 2019
Merged

Update gcp_compute_instance_facts.py #56581

merged 1 commit into from May 20, 2019

Conversation

fernandezcuesta
Copy link
Contributor

SUMMARY

Typo in filters URL

ISSUE TYPE
  • Docs Pull Request

+label: docsite_pr

SUMMARY

Swapped dot character inside brackets leads to wrong URL for gcloud topic filters

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

gcp_compute_instance_facts

ADDITIONAL INFORMATION
[...] (https://cloud.google.com/sdk/gcloud/reference/topic/filters).
instead of (https://cloud.google.com/sdk/gcloud/reference/topic/filters.).

@fernandezcuesta
Update gcp_compute_instance_facts.py
70a9034 
##### SUMMARY
swapped dot inside brackets leading to wrong url


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
@ansibot
Copy link
Contributor

ansibot commented May 17, 2019

cc @erjohnso @GoogleCloudPlatform @rambleraptor
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 cloud community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. gce module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels May 17, 2019
@acozine
Copy link
Contributor

acozine commented May 20, 2019

Nice catch, thanks @fernandezcuesta!

@acozine acozine removed the needs_triage Needs a first human triage before being processed. label May 20, 2019
@acozine acozine merged commit 2a90cbd into ansible:devel May 20, 2019
acozine pushed a commit to acozine/ansible that referenced this pull request May 20, 2019
@fernandezcuesta @acozine
Update gcp_compute_instance_facts.py (ansible#56581)
1f920e2 
swapped dot inside brackets leading to wrong url

(cherry picked from commit 2a90cbd)
@acozine acozine mentioned this pull request May 20, 2019
Merged
acozine added a commit that referenced this pull request May 20, 2019
@acozine
Update gcp_compute_instance_facts.py (#56581) (#56670)
e47c603 
swapped dot inside brackets leading to wrong url

(cherry picked from commit 2a90cbd)
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
@dagwieers dagwieers added the docsite_pr This PR is created from documentation using the "Edit on GitHub" link. label Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 cloud community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. docsite_pr This PR is created from documentation using the "Edit on GitHub" link. gce module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fernandezcuesta @ansibot @acozine @dagwieers