Make second group match of ufw status output optional #56678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.9
There was a problem hiding this comment.
Good catch! Thanks!
The tests are failling; I want to investigate this a bit, something looks fishy.
You need to add a changelog fragment: https://docs.ansible.com/ansible/latest/reference_appendices/release_and_maintenance.html#changelogs-how-to (see here for examples).
ansibot
removed
the
needs_triage
|
Found the problem; the comparison logic was kind of broken, I've pushed a fix for that into your branch. That should fix the tests. Do you want to add the changelog, or do you want me to do that? |
ansibot
added
community_review
|
Nice. I will go ahead and add it
…On Mon, May 20, 2019, 10:43 PM Felix Fontein ***@***.***> wrote:
Found the problem; the comparison logic was kind of broken, I've pushed a
fix for that into your branch. That should fix the tests. Do you want to
add the changelog, or do you want me to do that?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#56678?email_source=notifications&email_token=AAQVQQTNZ52PDR23QFFBL2LPWODZVA5CNFSM4HOGA7H2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV2Z6EY#issuecomment-494247699>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAQVQQUNNSQB36QRREY3XQLPWODZVANCNFSM4HOGA7HQ>
.
|
|
@ovcharenko @jbarotin anyone wants to take a look at this? |
|
LGTM |
|
shipit |
felixfontein
pushed a commit
to felixfontein/ansible
that referenced
this pull request
May 28, 2019
* Make second group match of ufw status output optional Fixes ansible#56674 * Fix comparison logic. * Add changelog fragment (cherry picked from commit 1d22909)
abadger
pushed a commit
that referenced
this pull request
May 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56674
SUMMARY
Second group match does not always exist. In cases where it is missing, like when logging is set to
off, allow regex to still succeed to return first group match such thatcurrent_on_off_valuewill be defined.ISSUE TYPE
COMPONENT NAME
ufw