Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply tags conditionally so that the module does not throw up an erro… #56710

Merged
merged 2 commits into from May 28, 2019
Merged

Apply tags conditionally so that the module does not throw up an erro… #56710

merged 2 commits into from May 28, 2019

Conversation

brtkwr
Copy link
Contributor

@brtkwr brtkwr commented May 21, 2019

…r when using an older distro of openstacksdk

(cherry picked from commit c517538)

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. openstack support:community This issue/PR relates to code supported by the Ansible community. labels May 21, 2019
@emonty
Copy link
Contributor

emonty commented May 21, 2019

shipit

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label May 21, 2019
@gtema
Copy link
Contributor

gtema commented May 21, 2019

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels May 21, 2019
@abadger
Copy link
Contributor

abadger commented May 22, 2019

Backports need to have a changelog fragment. This change looks good once a changelog fragment is added.

@abadger
Copy link
Contributor

abadger commented May 28, 2019

@brtknr Are you going to add a changelog fragment?

…r when using an older distro of openstacksdk

(cherry picked from commit c517538)
@brtkwr
Copy link
Contributor Author

brtkwr commented May 28, 2019

Done @abadger

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed shipit This PR is ready to be merged by Core labels May 28, 2019
@abadger abadger merged commit 7d9aa0d into ansible:stable-2.8 May 28, 2019
@abadger
Copy link
Contributor

abadger commented May 28, 2019

Merged for the 2.8.1 release.

@brtkwr brtkwr deleted the backport/2.8/56575 branch May 29, 2019 06:47
brtkwr added a commit to cedadev/jasmin-appliances that referenced this pull request Jun 3, 2019
The os_stack module does not get fixed until this version of Ansible as another bug had to be addressed: ansible/ansible#56710
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. openstack support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants