Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yum: handle "_none_" value for proxy #56725

Merged
merged 2 commits into from May 23, 2019
Merged

yum: handle "_none_" value for proxy #56725

merged 2 commits into from May 23, 2019

Conversation

mkrizek
Copy link
Contributor

@mkrizek mkrizek commented May 21, 2019

SUMMARY

Fixes #56538

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

yum

@mkrizek mkrizek requested a review from maxamillion May 21, 2019 14:59
@ansibot
Copy link
Contributor

ansibot commented May 21, 2019

cc @Akasurde @berenddeschouwer @kustodian @maxamillion @verm666
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. packaging Packaging category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels May 21, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 21, 2019
@maxamillion
Copy link
Contributor

rebuild_merge

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. labels May 23, 2019
@ansibot ansibot merged commit 7b9d7e6 into ansible:devel May 23, 2019
@mkrizek mkrizek deleted the issue-56538 branch May 23, 2019 14:45
mkrizek added a commit to mkrizek/ansible that referenced this pull request May 23, 2019
@mkrizek
yum: handle "_none_" value for proxy (ansible#56725)
462f94c 
* yum: handle "_none_" value for proxy

Fixes ansible#56538

* Fix sanity check

(cherry picked from commit 7b9d7e6)
@mkrizek mkrizek mentioned this pull request May 23, 2019
Merged
abadger pushed a commit that referenced this pull request May 24, 2019
@mkrizek @abadger
yum: handle "_none_" value for proxy (#56725)
eb9d192 
* yum: handle "_none_" value for proxy

Fixes #56538

* Fix sanity check

(cherry picked from commit 7b9d7e6)
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maxamillion maxamillion Awaiting requested review from maxamillion

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. module This issue/PR relates to a module. packaging Packaging category shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ansible reads proxy from yum.conf but doesn't handle _none_
3 participants
@mkrizek @ansibot @maxamillion