Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openssl_pkcs12: fix crash due to wrong path used for loading key in check mode #56808

Merged
merged 2 commits into from May 22, 2019
Merged

openssl_pkcs12: fix crash due to wrong path used for loading key in check mode #56808

merged 2 commits into from May 22, 2019

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Fixes #56792.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

openssl_pkcs12

@felixfontein felixfontein mentioned this pull request May 22, 2019
Closed
@ansibot
Copy link
Contributor

ansibot commented May 22, 2019

cc @MarkusTeufelberger @Shaps @Spredzy @Xyon @gdelpierre @puiterwijk @resmo
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. crypto Crypto community (ACME, openssl, letsencrypt) module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels May 22, 2019
@Shaps
Copy link
Contributor

Shaps commented May 22, 2019

shipit

resmo
resmo approved these changes May 22, 2019
View reviewed changes
Copy link
Contributor

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@resmo resmo merged commit 391a104 into ansible:devel May 22, 2019
@resmo
Copy link
Contributor

resmo commented May 22, 2019

manual merge due to changelog fragment blocks automerge.

@felixfontein felixfontein deleted the openssl_pkcs12-fix branch May 23, 2019 05:10
@felixfontein
Copy link
Contributor Author

@Shaps @resmo thanks for reviewing and merging!

felixfontein added a commit to felixfontein/ansible that referenced this pull request May 23, 2019
@felixfontein
openssl_pkcs12: fix crash due to wrong path used for loading key in c…
98d7e6e 
…heck mode (ansible#56808)

* Used wrong path for private key.

* Add changelog.

(cherry picked from commit 391a104)
@felixfontein felixfontein mentioned this pull request May 23, 2019
Merged
@finnje
Copy link

finnje commented May 23, 2019

@felixfontein thanks for the quick turnaround! Works like a champ now :)

@sivel sivel removed the needs_triage Needs a first human triage before being processed. label May 23, 2019
abadger pushed a commit that referenced this pull request May 24, 2019
@felixfontein @abadger
openssl_pkcs12: fix crash due to wrong path used for loading key in c…
6c078e1 
…heck mode (#56808)

* Used wrong path for private key.

* Add changelog.

(cherry picked from commit 391a104)
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@resmo resmo resmo approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. crypto Crypto community (ACME, openssl, letsencrypt) module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

openssl_pkcs12 'Error while deserializing key'
6 participants
@felixfontein @ansibot @Shaps @resmo @finnje @sivel