win_get_url: ignore defender false positive in tests #56812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @dagwieers @if-meaton @jhawkesworth @nitzmahone @tksarah |
ansibot
added
affects_2.9
jborean93
force-pushed
the
tests-win_get_url
branch
from
acadb2d
to
81ec523
Compare
jborean93
force-pushed
the
tests-win_get_url
branch
from
81ec523
to
90275db
Compare
ansibot
added
core_review
mattclay
approved these changes
May 23, 2019
mattclay
removed
the
needs_triage
mattclay
changed the title
mattclay
changed the title
mattclay
pushed a commit
to mattclay/ansible
that referenced
this pull request
May 23, 2019
…sible#56812) (cherry picked from commit 124400f) Co-authored-by: Jordan Borean <jborean93@gmail.com>
mattclay
pushed a commit
to mattclay/ansible
that referenced
this pull request
May 23, 2019
…sible#56812) (cherry picked from commit 124400f) Co-authored-by: Jordan Borean <jborean93@gmail.com>
mattclay
pushed a commit
to mattclay/ansible
that referenced
this pull request
May 23, 2019
…sible#56812) (cherry picked from commit 124400f) Co-authored-by: Jordan Borean <jborean93@gmail.com>
This was referenced May 23, 2019
abadger
pushed a commit
that referenced
this pull request
May 23, 2019
abadger
pushed a commit
that referenced
this pull request
May 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
We are seeing more errors in trying to start this service that is intermittent https://app.shippable.com/github/ansible/ansible/runs/124053/14/tests.
This adds a retry on this task to try again instead of failing straight away.It seems like the binary is being flagged as a false positive virus by Windows. This adds an exclusion for that binary until we get a better solution to replace it.
ISSUE TYPE
COMPONENT NAME
win_get_url tests