Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport/2.8/56703 #56829

Merged
merged 2 commits into from May 24, 2019
Merged

Backport/2.8/56703 #56829

merged 2 commits into from May 24, 2019

Conversation

Andersson007
Copy link
Contributor

SUMMARY

Backport PR for #56734

ISSUE TYPE
  • Bugfix Pull Request

@ansibot
Copy link
Contributor

ansibot commented May 23, 2019

cc @Dorn- @amenonsen @andytom @jbscalia @kostiantyn-nemchenko @kustodian @matburt @nerzhul @sebasmannem @tcraxs
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. database Database category module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. postgresql PostgreSQL community support:community This issue/PR relates to code supported by the Ansible community. labels May 23, 2019
@andytom
Copy link
Contributor

andytom commented May 23, 2019

LGTM

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels May 23, 2019
@abadger abadger merged commit 206087e into ansible:stable-2.8 May 24, 2019
@abadger
Copy link
Contributor

abadger commented May 24, 2019

Merged for the 2.8.1 release.

This causes a regression but we decided this was allowable for two reasons:

  • The bug this causes is worse than the bug it fixed
  • The change only appeared in 2.8.0 so we can treat the bug it caused as a regression from 2.7.x.

@Andersson007
Copy link
Contributor Author

@andytom , thank you for reviewing
@abadger , thank you for merging. I’m going open a new issue for the old bug on Monday

@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. database Database category module This issue/PR relates to a module. postgresql PostgreSQL community shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Andersson007 @ansibot @andytom @abadger