Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copyright fix for 2018 #56860

Merged
merged 2 commits into from May 23, 2019
Merged

Copyright fix for 2018 #56860

merged 2 commits into from May 23, 2019

Conversation

samccann
Copy link
Contributor

SUMMARY

Update RST page copyright annually. Also remove extra copyright from CLI commands since that is covered by the footer copyright.

partially addresses #45989

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME

docs.ansible.com

ADDITIONAL INFORMATION

@samccann samccann added docs This issue/PR relates to or includes documentation. affects_2.9 This issue/PR affects Ansible v2.9 labels May 23, 2019
@samccann samccann added this to To do in OLD Ansible Documentation via automation May 23, 2019
@sivel
Copy link
Member

sivel commented May 23, 2019

I'm not as familiar with copyright on web pages, as I am with how we handle copyright in code, but this goes in a completely different direction from what we have been advised to do in code.

Many developers wrestle with what to put in the year of a copyright notice, and whether and when to update it. For projects using a per-fileapproach with copyright notices, I now recommend following the practice, which again first came to my attention when Google adopted it, which is to use the year of file creation and never to update it despite future changes to the file. This is a rather arbitrary approach from a legal standpoint but it seems easy for projects to administer and it is unlikely to cause any interesting legal issues.

From my understanding, simply bumping a single year forward, means that content created in previous years is no longer covered by the copyright.

@ansibot
Copy link
Contributor

ansibot commented May 23, 2019

cc @acozine
click here for bot help

@ansibot ansibot added bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels May 23, 2019
@acozine
Copy link
Contributor

acozine commented May 23, 2019

@sivel I was surprised as well. We knew the existing footer copyright (Copyright © 2018 Red Hat, Inc.) was incorrect - since we had content that was older than 2018 and content that was newer as well. We weren't sure whether to put the oldest date, or the newest, or a range. We asked for guidance from RH's legal department, and they directed us to update the footer copyright for the docsite to the current year and the current year only. It's different from code copyrighting, but we're adopting their recommendation.

@sivel
Copy link
Member

sivel commented May 23, 2019

@acozine I appreciate the follow up!

@acozine acozine merged commit f9b43a0 into ansible:devel May 23, 2019
samccann added a commit to samccann/ansible that referenced this pull request May 23, 2019
@samccann
Copyright fix for 2018 (ansible#56860)
db2c5fc 
* update copyright in footer

* remove extraneous copyright from cli commands

(cherry picked from commit f9b43a0)
acozine pushed a commit that referenced this pull request May 23, 2019
@samccann @acozine
Copyright fix for 2018 (#56860) (#56869)
48189b9 
* update copyright in footer

* remove extraneous copyright from cli commands

(cherry picked from commit f9b43a0)
This was referenced May 23, 2019
Merged
Merged
@samccann samccann deleted the copyright-fix branch June 5, 2019 20:51
@samccann samccann moved this from To do to In progress in OLD Ansible Documentation Jun 10, 2019
@samccann samccann moved this from In progress to Done in OLD Ansible Documentation Jun 10, 2019
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
OLD Ansible Documentation
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@samccann @sivel @ansibot @acozine