Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker_container: improve docs w.r.t. networks_cli_compatible. #56971

Merged
merged 1 commit into from
Jun 3, 2019
Merged

docker_container: improve docs w.r.t. networks_cli_compatible. #56971

merged 1 commit into from
Jun 3, 2019

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Improves the documentation of networks_cli_compatible: state that network_mode also has to be set to be more closer to docker CLI's behavior. Fixes #56963.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

docker_container

@felixfontein felixfontein mentioned this pull request May 26, 2019
Closed
@felixfontein felixfontein changed the title [2.8] Improve docs w.r.t. networks_cli_compatible. Improve docs w.r.t. networks_cli_compatible. May 26, 2019
@felixfontein felixfontein changed the title Improve docs w.r.t. networks_cli_compatible. docker_container: improve docs w.r.t. networks_cli_compatible. May 26, 2019
@ansibot
Copy link
Contributor

ansibot commented May 26, 2019

cc @DBendit @WojciechowskiPiotr @akshay196 @chouseknecht @cove @danihodovic @dariko @dusdanig @joshuaconner @jwitko @kassiansun @softzilla @tbouvet @zfil
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. docker module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels May 26, 2019
@felixfontein
Copy link
Contributor Author

BTW: this one really needs a review. :)

akshay196
akshay196 approved these changes Jun 3, 2019
View reviewed changes
Copy link
Contributor

@akshay196 akshay196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Jun 3, 2019
@ansibot ansibot merged commit b33c9da into ansible:devel Jun 3, 2019
@felixfontein felixfontein deleted the docker_container-networks_cli_compatible-docs branch June 3, 2019 04:38
@felixfontein
Copy link
Contributor Author

@akshay196 thanks for reviewing this!

felixfontein added a commit to felixfontein/ansible that referenced this pull request Jun 3, 2019
@felixfontein
Improve docs w.r.t. networks_cli_compatible. (ansible#56971)
f0a36d9 
(cherry picked from commit b33c9da)
@felixfontein felixfontein mentioned this pull request Jun 3, 2019
Merged
abadger pushed a commit that referenced this pull request Jun 3, 2019
@felixfontein @abadger
Improve docs w.r.t. networks_cli_compatible. (#56971)
503eaea 
(cherry picked from commit b33c9da)
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@akshay196 akshay196 akshay196 approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. cloud docker module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docker_container networks not changing network_mode
3 participants
@felixfontein @ansibot @akshay196