Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add terminal initial prompt for initial connection #57057

Merged
merged 1 commit into from
May 29, 2019
Merged

add terminal initial prompt for initial connection #57057

merged 1 commit into from
May 29, 2019

Conversation

yuandongx
Copy link
Contributor

SUMMARY

add terminal initial prompt for initial connection

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/plugins/terminal/ce.py

ADDITIONAL INFORMATION
When CE establishes an initial connection, it may prompt that passwords need to be changed.If there is no anser until time is out , the connection will be failed.So create this PR to fix it.

yuandongx
yuandongx commented May 28, 2019
View reviewed changes
lib/ansible/plugins/terminal/ce.py
@@ -31,7 +31,13 @@ class TerminalModule(TerminalBase):
re.compile(br'[\r\n]?<.+>(?:\s*)$'),
re.compile(br'[\r\n]?\[.+\](?:\s*)$'),
]
#: terminal initial prompt
#: The password needs to be changed. Change now? [Y/N]:
terminal_initial_prompt = br'Change\s*now\s*\?\s*\[Y\/N\]\s*:'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the initial connection, there may be prompts to change the password.
But password modification is not allowed.and password modification requires interaction.
So do not!

@yuandongx yuandongx mentioned this pull request May 28, 2019
Closed
@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. networking Network category small_patch support:community This issue/PR relates to code supported by the Ansible community. labels May 28, 2019
@Qalthos Qalthos merged commit 9e1f184 into ansible:devel May 29, 2019
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label May 29, 2019
abadger pushed a commit that referenced this pull request May 30, 2019
@abadger
Backport/2.8/57057 add terminal initial prompt for initial connection (…
19ffe97 
…#57178)

* add terminal initial prompt for initial connection (#57057)


(cherry picked from commit 9e1f184)

* changelogs fragments

* update changelogs fragments
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
@yuandongx yuandongx deleted the terminal_ce branch September 16, 2019 09:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. networking Network category small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yuandongx @sivel @Qalthos @ansibot