Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Facts dev upstream #57082

Merged
merged 3 commits into from Aug 8, 2019
Merged

Facts dev upstream #57082

merged 3 commits into from Aug 8, 2019

Conversation

ndswartz
Copy link
Contributor

SUMMARY

Added the following facts:

storage system segment size
cache block size capabilities
workload tags
storage array hosts
host groups
list of mapped volumes for each initiator
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

netapp_e_facts

ADDITIONAL INFORMATION
ansible 2.8.0.dev0
  config file = None
  configured module search path = [u'/home/swartzn/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/swartzn/ansible-dev/lib/ansible
  executable location = /home/swartzn/ansible-dev/bin/ansible
  python version = 2.7.15rc1 (default, Nov 12 2018, 14:31:15) [GCC 7.3.0]

@ansibot
Copy link
Contributor

ansibot commented May 28, 2019

cc @amit0701 @carchi8py @hulquest @lmprice @lonico @schmots1
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. netapp owner_pr This PR is made by the module's maintainer. storage support:community This issue/PR relates to code supported by the Ansible community. labels May 28, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 5, 2019
@thedoubl3j thedoubl3j self-assigned this Jul 29, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jul 31, 2019
@thedoubl3j
Copy link
Member

@ndswartz I am not seeing any testing for this at all, could we get some coverage on this?

@swartzn
Improved netapp_e_facts module.
6cafaee 
Added the following facts:
  - storage system segment size
  - cache block size capabilities
  - workload tags
  - storage array hosts
  - host groups
  - list of mapped volumes for each initiator
@swartzn
Remove proxy specific facts from netapp_e_facts module
6f3c299
@ansibot
Copy link
Contributor

ansibot commented Aug 7, 2019

The test ansible-test sanity --test pep8 [explain] failed with 42 errors:

test/units/modules/storage/netapp/test_netapp_e_facts.py:57:42: E122 continuation line missing indentation or outdented
test/units/modules/storage/netapp/test_netapp_e_facts.py:60:42: E122 continuation line missing indentation or outdented
test/units/modules/storage/netapp/test_netapp_e_facts.py:63:42: E122 continuation line missing indentation or outdented
test/units/modules/storage/netapp/test_netapp_e_facts.py:66:42: E122 continuation line missing indentation or outdented
test/units/modules/storage/netapp/test_netapp_e_facts.py:69:42: E122 continuation line missing indentation or outdented
test/units/modules/storage/netapp/test_netapp_e_facts.py:70:42: E122 continuation line missing indentation or outdented
test/units/modules/storage/netapp/test_netapp_e_facts.py:71:42: E122 continuation line missing indentation or outdented
test/units/modules/storage/netapp/test_netapp_e_facts.py:72:44: E126 continuation line over-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_facts.py:83:17: E121 continuation line under-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_facts.py:86:26: E122 continuation line missing indentation or outdented
test/units/modules/storage/netapp/test_netapp_e_facts.py:87:26: E122 continuation line missing indentation or outdented
test/units/modules/storage/netapp/test_netapp_e_facts.py:91:26: E122 continuation line missing indentation or outdented
test/units/modules/storage/netapp/test_netapp_e_facts.py:92:26: E122 continuation line missing indentation or outdented
test/units/modules/storage/netapp/test_netapp_e_facts.py:94:26: E122 continuation line missing indentation or outdented
test/units/modules/storage/netapp/test_netapp_e_facts.py:95:26: E122 continuation line missing indentation or outdented
test/units/modules/storage/netapp/test_netapp_e_facts.py:127:41: E122 continuation line missing indentation or outdented
test/units/modules/storage/netapp/test_netapp_e_facts.py:130:41: E122 continuation line missing indentation or outdented
test/units/modules/storage/netapp/test_netapp_e_facts.py:131:41: E122 continuation line missing indentation or outdented
test/units/modules/storage/netapp/test_netapp_e_facts.py:133:41: E122 continuation line missing indentation or outdented
test/units/modules/storage/netapp/test_netapp_e_facts.py:135:90: E126 continuation line over-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_facts.py:136:46: E126 continuation line over-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_facts.py:146:22: E126 continuation line over-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_facts.py:150:22: E122 continuation line missing indentation or outdented
test/units/modules/storage/netapp/test_netapp_e_facts.py:151:22: E122 continuation line missing indentation or outdented
test/units/modules/storage/netapp/test_netapp_e_facts.py:152:71: E126 continuation line over-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_facts.py:232:17: E121 continuation line under-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_facts.py:255:17: E121 continuation line under-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_facts.py:263:13: E122 continuation line missing indentation or outdented
test/units/modules/storage/netapp/test_netapp_e_facts.py:266:17: E121 continuation line under-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_facts.py:273:13: E122 continuation line missing indentation or outdented
test/units/modules/storage/netapp/test_netapp_e_facts.py:276:17: E121 continuation line under-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_facts.py:283:13: E122 continuation line missing indentation or outdented
test/units/modules/storage/netapp/test_netapp_e_facts.py:286:17: E121 continuation line under-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_facts.py:293:13: E122 continuation line missing indentation or outdented
test/units/modules/storage/netapp/test_netapp_e_facts.py:296:17: E121 continuation line under-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_facts.py:303:13: E122 continuation line missing indentation or outdented
test/units/modules/storage/netapp/test_netapp_e_facts.py:306:13: E122 continuation line missing indentation or outdented
test/units/modules/storage/netapp/test_netapp_e_facts.py:309:13: E122 continuation line missing indentation or outdented
test/units/modules/storage/netapp/test_netapp_e_facts.py:312:13: E122 continuation line missing indentation or outdented
test/units/modules/storage/netapp/test_netapp_e_facts.py:335:13: E126 continuation line over-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_facts.py:347:33: E126 continuation line over-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_facts.py:357:17: E121 continuation line under-indented for hanging indent

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 7, 2019

cc @mattclay
click here for bot help

@ansibot ansibot removed the community_review In order to be merged, this PR must follow the community review workflow. label Aug 7, 2019
@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. and removed owner_pr This PR is made by the module's maintainer. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Aug 7, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 7, 2019

cc @mattclay
click here for bot help

@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Aug 7, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 7, 2019

The test ansible-test sanity --test pep8 [explain] failed with 12 errors:

test/units/modules/storage/netapp/test_netapp_e_facts.py:84:17: E121 continuation line under-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_facts.py:141:90: E126 continuation line over-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_facts.py:152:22: E126 continuation line over-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_facts.py:241:17: E121 continuation line under-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_facts.py:264:17: E121 continuation line under-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_facts.py:276:17: E121 continuation line under-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_facts.py:286:17: E121 continuation line under-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_facts.py:296:17: E121 continuation line under-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_facts.py:306:17: E121 continuation line under-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_facts.py:345:13: E126 continuation line over-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_facts.py:357:33: E126 continuation line over-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_facts.py:367:17: E121 continuation line under-indented for hanging indent

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Aug 7, 2019
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Aug 7, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 7, 2019

The test ansible-test sanity --test pep8 [explain] failed with 6 errors:

test/units/modules/storage/netapp/test_netapp_e_facts.py:144:64: E126 continuation line over-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_facts.py:166:52: E126 continuation line over-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_facts.py:272:17: E121 continuation line under-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_facts.py:357:13: E126 continuation line over-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_facts.py:369:33: E126 continuation line over-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_facts.py:379:17: E121 continuation line under-indented for hanging indent

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Aug 7, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 7, 2019

The test ansible-test sanity --test pep8 [explain] failed with 6 errors:

test/units/modules/storage/netapp/test_netapp_e_facts.py:144:64: E126 continuation line over-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_facts.py:166:52: E126 continuation line over-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_facts.py:272:17: E121 continuation line under-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_facts.py:357:13: E126 continuation line over-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_facts.py:369:33: E126 continuation line over-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_facts.py:379:17: E121 continuation line under-indented for hanging indent

click here for bot help

@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Aug 8, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 8, 2019

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

test/units/modules/storage/netapp/test_netapp_e_facts.py:407:13: E126 continuation line over-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_facts.py:411:33: E126 continuation line over-indented for hanging indent

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Aug 8, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 8, 2019

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

test/units/modules/storage/netapp/test_netapp_e_facts.py:407:13: E126 continuation line over-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_facts.py:411:33: E126 continuation line over-indented for hanging indent

click here for bot help

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 8, 2019
@ndswartz ndswartz closed this Aug 8, 2019
@ndswartz ndswartz reopened this Aug 8, 2019
@ndswartz
Copy link
Contributor Author

ndswartz commented Aug 8, 2019

@thedoubl3j Added unit test coverage

@ndswartz ndswartz closed this Aug 8, 2019
@ndswartz ndswartz reopened this Aug 8, 2019
@thedoubl3j
Copy link
Member

thank you @ndswartz reviewing now

thedoubl3j
thedoubl3j approved these changes Aug 8, 2019
View reviewed changes
Copy link
Member

@thedoubl3j thedoubl3j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for adding some coverage.

@anshulbehl anshulbehl self-requested a review August 8, 2019 15:35
@anshulbehl anshulbehl merged commit 10543c8 into ansible:devel Aug 8, 2019
@ansible ansible locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anshulbehl anshulbehl anshulbehl approved these changes

@thedoubl3j thedoubl3j thedoubl3j approved these changes

Assignees

@thedoubl3j thedoubl3j

Labels
affects_2.9 This issue/PR affects Ansible v2.9 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. netapp storage support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ndswartz @ansibot @thedoubl3j @anshulbehl @swartzn