Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport/2.8/57135 #57137

Merged
merged 2 commits into from
May 29, 2019
Merged

Backport/2.8/57135 #57137

merged 2 commits into from
May 29, 2019

Conversation

ndswartz
Copy link
Contributor

SUMMARY

Fix CHAP secret allowable length and ability to clear the password.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

netapp_e_iscsi_target

ADDITIONAL INFORMATION

iSCSI CHAP secret is prevented from being up to 57 characters and the modules fails when empty string is passed to clear the password.

ansible 2.9.0.dev0
  config file = None
  configured module search path = [u'/home/swartzn/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/swartzn/ansible-dev/lib/ansible
  executable location = /home/swartzn/ansible-dev/bin/ansible
  python version = 2.7.15rc1 (default, Nov 12 2018, 14:31:15) [GCC 7.3.0]

@ansibot
Copy link
Contributor

ansibot commented May 29, 2019

cc @amit0701 @carchi8py @hulquest @lmprice @lonico @schmots1
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. netapp storage support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels May 29, 2019
@abadger abadger merged commit 0365d73 into ansible:stable-2.8 May 29, 2019
@abadger
Copy link
Contributor

abadger commented May 29, 2019

Merged for the 2.8.1 release.

@sivel sivel removed the needs_triage Needs a first human triage before being processed. label May 30, 2019
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. netapp storage support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ndswartz @ansibot @abadger @sivel @swartzn