Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update docsite breadcrumbs from sphinx_rtd_theme #57316

Merged
merged 4 commits into from
Jun 5, 2019
Merged

update docsite breadcrumbs from sphinx_rtd_theme #57316

merged 4 commits into from
Jun 5, 2019

Conversation

samccann
Copy link
Contributor

@samccann samccann commented Jun 3, 2019 •
edited

SUMMARY

Use latest breadcrumbs from sphinx_rtd_theme

Partially addresses proposal 147:
ansible/proposals#147

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

docs.ansible.com

ADDITIONAL INFORMATION

@samccann samccann added docs This issue/PR relates to or includes documentation. affects_2.9 This issue/PR affects Ansible v2.9 labels Jun 3, 2019
@samccann samccann added this to To do in OLD Ansible Documentation via automation Jun 3, 2019
@samccann samccann changed the title [WIP] update docsite breadcrumbs from sphinx_rtd_theme ]update docsite breadcrumbs from sphinx_rtd_theme Jun 3, 2019
@samccann samccann changed the title ]update docsite breadcrumbs from sphinx_rtd_theme update docsite breadcrumbs from sphinx_rtd_theme Jun 3, 2019
@ansibot
Copy link
Contributor

ansibot commented Jun 3, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

docs/docsite/rst/conf.py:143:3: E121 continuation line under-indented for hanging indent

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jun 3, 2019

cc @acozine
click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jun 3, 2019
@samccann samccann removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jun 3, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. labels Jun 3, 2019
@acozine acozine mentioned this pull request Jun 4, 2019
Closed
@acozine acozine merged commit 3136007 into ansible:devel Jun 5, 2019
samccann added a commit to samccann/ansible that referenced this pull request Jun 5, 2019
@samccann
update docsite breadcrumbs from sphinx_rtd_theme (ansible#57316)
09e7526 
* improve breadcrumbs
* get edit on github working again
(cherry picked from commit 3136007)
@samccann samccann mentioned this pull request Jun 5, 2019
Merged
acozine pushed a commit that referenced this pull request Jun 5, 2019
@samccann @acozine
update docsite breadcrumbs from sphinx_rtd_theme (#57316) (#57423)
69696dc 
* improve breadcrumbs
* get edit on github working again
(cherry picked from commit 3136007)
@samccann samccann mentioned this pull request Jun 5, 2019
Merged
@samccann samccann deleted the breadcrumb-fix branch June 5, 2019 20:20
@samccann samccann moved this from To do to Backport to 2.7 in OLD Ansible Documentation Jun 10, 2019
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samccann @ansibot @acozine