Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add uid, and gid to volume clone #57371

Merged
merged 5 commits into from
Jul 11, 2019
Merged

Add uid, and gid to volume clone #57371

merged 5 commits into from
Jul 11, 2019

Conversation

carchi8py
Copy link
Contributor

SUMMARY

Add UID, and Gid to volume clone

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • na_ontap_volume_clone.py
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Jun 4, 2019

cc @amit0701 @hulquest @lmprice @lonico @ndswartz @schmots1
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. netapp owner_pr This PR is made by the module's maintainer. storage support:community This issue/PR relates to code supported by the Ansible community. labels Jun 4, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jun 5, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 13, 2019
@ansibot
Copy link
Contributor

ansibot commented Jun 17, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

test/sanity/validate-modules/ignore.txt:3579:1: A102 Remove since "lib/ansible/modules/storage/netapp/na_ontap_volume_clone.py" passes "E337" test

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jun 17, 2019
@ansibot
Copy link
Contributor

ansibot commented Jun 17, 2019

cc @mattclay
click here for bot help

@ansibot ansibot added support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. owner_pr This PR is made by the module's maintainer. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 17, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jun 17, 2019
lonico
lonico approved these changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@lonico lonico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@carchi8py
Copy link
Contributor Author

Not sure what happened here all the build failed unable to find the change

ERROR: Commit c9ae110 was not found:

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 19, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed shipit This PR is ready to be merged by Core labels Jun 27, 2019
lonico
lonico approved these changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@lonico lonico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jul 9, 2019
JohnLieske
JohnLieske approved these changes Jul 10, 2019
View reviewed changes
Copy link

@JohnLieske JohnLieske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@thedoubl3j
Copy link
Member

@carchi8py are there any tests for this module? unit or otherwise?

@carchi8py
Copy link
Contributor Author

Sorry about that @thedoubl3j completely forgot to push the unit test as well. Put it out now.

lonico
lonico approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@lonico lonico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@JohnLieske
Copy link

Good to go
=========================== 5 passed in 1.90 seconds ===========================

@JohnLieske JohnLieske merged commit 59feb63 into ansible:devel Jul 11, 2019
@ansible ansible locked and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lonico lonico lonico approved these changes

@JohnLieske JohnLieske JohnLieske approved these changes

Assignees

@JohnLieske JohnLieske

Labels
affects_2.9 This issue/PR affects Ansible v2.9 feature This issue/PR relates to a feature request. module This issue/PR relates to a module. netapp shipit This PR is ready to be merged by Core storage support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@carchi8py @ansibot @thedoubl3j @JohnLieske @lonico