Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set vscan_fileop_profile for na_ontap_cifs #57373

Merged
merged 2 commits into from
Jul 11, 2019
Merged

Set vscan_fileop_profile for na_ontap_cifs #57373

merged 2 commits into from
Jul 11, 2019

Conversation

carchi8py
Copy link
Contributor

@carchi8py carchi8py commented Jun 4, 2019 •
edited

SUMMARY

Set vscan_fileop_profile for na_ontap_cifs

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • na_ontap_cifs.py
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Jun 4, 2019

cc @amit0701 @hulquest @lmprice @lonico @ndswartz @schmots1
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 committer_review In order to be merged, this PR must follow the certified review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. netapp storage support:certified This issue/PR relates to certified code. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Jun 4, 2019
@ansibot
Copy link
Contributor

ansibot commented Jun 4, 2019

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

test/units/modules/storage/netapp/test_na_ontap_cifs.py:79:32: duplicate-key Duplicate key 'cifs-share-properties' in dictionary
test/units/modules/storage/netapp/test_na_ontap_cifs.py:81:34: duplicate-key Duplicate key 'cifs-share-symlink-properties' in dictionary

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed committer_review In order to be merged, this PR must follow the certified review workflow. labels Jun 4, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jun 5, 2019
@carchi8py carchi8py changed the title Set vscan_fileop_profile for na_ontap_cids Set vscan_fileop_profile for na_ontap_cifs Jun 5, 2019
@thedoubl3j thedoubl3j self-assigned this Jun 13, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 13, 2019
@ansibot ansibot added committer_review In order to be merged, this PR must follow the certified review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jun 17, 2019
lonico
lonico approved these changes Jun 24, 2019
View reviewed changes
Copy link
Contributor

@lonico lonico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed committer_review In order to be merged, this PR must follow the certified review workflow. labels Jul 2, 2019
thedoubl3j
thedoubl3j approved these changes Jul 11, 2019
View reviewed changes
Copy link
Member

@thedoubl3j thedoubl3j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tests updated and docs updated.

@thedoubl3j thedoubl3j merged commit 6e3d54a into ansible:devel Jul 11, 2019
@ansible ansible locked and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lonico lonico lonico approved these changes

@thedoubl3j thedoubl3j thedoubl3j approved these changes

Assignees

@thedoubl3j thedoubl3j

Labels
affects_2.9 This issue/PR affects Ansible v2.9 feature This issue/PR relates to a feature request. module This issue/PR relates to a module. netapp shipit This PR is ready to be merged by Core storage support:certified This issue/PR relates to certified code. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@carchi8py @ansibot @lonico @thedoubl3j