Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ovirt_vm: Fix issue in resetting the storage domain lease #57469

Merged
merged 1 commit into from Jun 12, 2019
Merged

ovirt_vm: Fix issue in resetting the storage domain lease #57469

merged 1 commit into from Jun 12, 2019

Conversation

nijinashok
Copy link
Contributor

SUMMARY

Currently, if we pass an empty string to lease, it will fail with the error "Exception: Entity '' was not found." There is no way to reset/remove the lease of a VM. The patch fixes the same and it allows to remove the storage domain lease by passing an empty string.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ovirt_vm

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Jun 6, 2019

cc @machacekondra @mnecas @mwperina
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. ovirt oVirt and RHV community small_patch support:community This issue/PR relates to code supported by the Ansible community. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jun 6, 2019
@nijinashok
ovirt_vm: Fix issue in resetting the storage domain lease
6c86ec1 
Currently, there is no way to remove the lease. The patch allows to
reset it by passing an empty string ('') to lease.
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 7, 2019
@machacekondra
Copy link
Contributor

shipit

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jun 12, 2019
@mnecas
Copy link
Contributor

mnecas commented Jun 12, 2019

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jun 12, 2019
@ansibot ansibot merged commit 166a5c9 into ansible:devel Jun 12, 2019
machacekondra pushed a commit to machacekondra/ansible that referenced this pull request Jun 12, 2019
@nijinashok @machacekondra
ovirt_vm: Fix issue in resetting the storage domain lease (ansible#57469
e14f026 
)

Currently, there is no way to remove the lease. The patch allows to
reset it by passing an empty string ('') to lease.
@machacekondra machacekondra mentioned this pull request Jun 12, 2019
Merged
abadger pushed a commit that referenced this pull request Jun 18, 2019
@nijinashok @abadger
ovirt_vm: Fix issue in resetting the storage domain lease (#57469)
bad860a 
Currently, there is no way to remove the lease. The patch allows to
reset it by passing an empty string ('') to lease.
agowa pushed a commit to agowa/ansible-1 that referenced this pull request Jun 30, 2019
@nijinashok @agowa
ovirt_vm: Fix issue in resetting the storage domain lease (ansible#57469
b7291a3 
)

Currently, there is no way to remove the lease. The patch allows to
reset it by passing an empty string ('') to lease.
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. ovirt oVirt and RHV community shipit This PR is ready to be merged by Core small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nijinashok @ansibot @machacekondra @mnecas