Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meraki_snmp - Add support for network SNMP settings #57708

Merged
merged 2 commits into from
Jul 31, 2019
Merged

meraki_snmp - Add support for network SNMP settings #57708

merged 2 commits into from
Jul 31, 2019

Conversation

kbreit
Copy link
Contributor

@kbreit kbreit commented Jun 11, 2019

SUMMARY
  • Network SNMP settings were added to the API
  • Parameters are different so it's a new data structure
  • Full suite of integration tests
  • Commit includes some cleanup as well
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

meraki_snmp

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 cisco Cisco technologies community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. meraki Cisco Meraki community module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 11, 2019
@kbreit kbreit mentioned this pull request Jun 12, 2019
Closed
@kbreit kbreit force-pushed the meraki/snmp_net_functions branch from 70bcab1 to 32e7b42 Compare June 18, 2019 01:28
@kbreit
meraki_snmp module supports network SNMP settings
e79774f 
- Network SNMP settings were added to the API
- Parameters are different so it's a new data structure
- Full suite of integration tests
- Commit includes some cleanup as well
@kbreit
Add reset task for SNMPv3
636255b
@kbreit kbreit force-pushed the meraki/snmp_net_functions branch from 32e7b42 to 636255b Compare June 20, 2019 01:57
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 28, 2019
@ansibot ansibot added has_issue and removed needs_triage Needs a first human triage before being processed. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jul 24, 2019
@Qalthos Qalthos merged commit d105c20 into ansible:devel Jul 31, 2019
@ansible ansible locked and limited conversation to collaborators Aug 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Qalthos Qalthos Qalthos approved these changes

@pabelanger pabelanger pabelanger approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 cisco Cisco technologies community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. has_issue meraki Cisco Meraki community module This issue/PR relates to a module. networking Network category support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kbreit @Qalthos @pabelanger @ansibot