ansible fails to detect Nutanix AHV virtualization facts

[jjh74]

SUMMARY

ansible-2.8.0 doesn't detect virtualization facts when VM is running on Nutanix AHV hypervisor.

ISSUE TYPE

• Bug Report
  (I created a patch for this: https://github.com/jjh74/ansible/commit/024549e97eaabb12ba7f4787b3bfaa8fb51880a9
  if it looks reasonable I can create a pull request).

COMPONENT NAME

module_utils/facts/virtual/linux.py

ANSIBLE VERSION

ansible 2.8.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.5 (default, Apr  9 2019, 14:30:50) [GCC 4.8.5 20150623 (Red Hat 4.8.5-36)]

Same results with:

ansible 2.8.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = ['/root/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python3.6/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 3.6.8 (default, Apr  3 2019, 17:26:03) [GCC 8.2.1 20180905 (Red Hat 8.2.1-3)]

CONFIGURATION

HOST_KEY_CHECKING(/home/username/.ansible.cfg) = True

OS / ENVIRONMENT

When VM is running on Nutanix AHV:

• /sys/devices/virtual/dmi/id/product_name == 'AHV'
• /sys/devices/virtual/dmi/id/sys_vendor == 'Nutanix'
• /sys/devices/virtual/dmi/id/bios_vendor == 'SeaBIOS' (SeaBIOS when VM is using BIOS, AFAIK UEFI has different 'bios' vendor).

STEPS TO REPRODUCE

ansible -m setup localhost
...
"ansible_virtualization_role": "NA",
"ansible_virtualization_type": "NA",
...

EXPECTED RESULTS

ansible -m setup localhost should return for example:
...
"ansible_virtualization_role": "guest",
"ansible_virtualization_type": "kvm",
...

ACTUAL RESULTS

...
       "ansible_system_vendor": "Nutanix",
...
        "ansible_virtualization_role": "NA",
        "ansible_virtualization_type": "NA",
...

[ansibot]

Files identified in the description:

• lib/ansible/module_utils/facts/virtual/linux.py

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[samdoran]

Did this work in previous versions or Ansible?

needs_info

[jjh74]

Doesn't seem to work on previous versions:

Tested with rpm packages from releases.ansible.com/ansible/rpm/release/epel-7-x86_64/
ansible 2.6.2
python version = 2.7.5 (default, Apr 9 2019, 14:30:50) [GCC 4.8.5 20150623 (Red Hat 4.8.5-36)]:

        "ansible_virtualization_role": "NA",
        "ansible_virtualization_type": "NA",

ansible 2.4.6.0
python version = 2.7.5 (default, Apr 9 2019, 14:30:50) [GCC 4.8.5 20150623 (Red Hat 4.8.5-36)]

        "ansible_virtualization_role": "NA",
        "ansible_virtualization_type": "NA",

ansible 2.2.3.0 (from releases.ansible.com/ansible/rpm/nightly/stable-2.2/epel-7-x86_64/)

        "ansible_virtualization_role": "NA",
        "ansible_virtualization_type": "NA",

[samdoran]

Thank you for the information. I just wanted to verify this isn't a regression. Please submit a PR that adds support for gathering facts on Nutanix AHV, including tests.

[jjh74]

I just created a PR(#58327). Unfortunately it doesn't include tests, I didn't find any existing unit tests that mock virtual facts. I'll read https://docs.ansible.com/ansible/latest/dev_guide/testing_units.html#testing-units and see if I can come up with unit tests for this.

[jjh74]

So far I haven't had time to create tests for this. Is the PR ok without tests or are tests required ?

[Akasurde]

Closing this as PR #58327 merged. @jjh74 Thanks for the contribution.