Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport/2.8/57617 #57756

Merged
merged 3 commits into from Jun 18, 2019
Merged

Backport/2.8/57617 #57756

merged 3 commits into from Jun 18, 2019

Conversation

mmazur
Copy link
Contributor

@mmazur mmazur commented Jun 12, 2019

SUMMARY

Function call was inconsistent with the intention (as expressed by the accompanying comment). This patch fixes that.

Fixes kubevirt/ansible-kubevirt-modules/issues/242

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

module/kubevirt_pvc

@ansibot
Copy link
Contributor

ansibot commented Jun 12, 2019

cc @kubevirt @machacekondra @pkliczewski
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Jun 12, 2019
@pkliczewski
Copy link

+1

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Jun 13, 2019
@mmazur @abadger
Drop superfluous dict()
f68c030 
Co-Authored-By: Toshio Kuratomi <a.badger@gmail.com>
@mmazur
Copy link
Contributor Author

mmazur commented Jun 18, 2019

Suggestion applied.

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed shipit This PR is ready to be merged by Core small_patch labels Jun 18, 2019
@abadger
Copy link
Contributor

abadger commented Jun 18, 2019

Merged for the 2.8.2 release.

@abadger abadger merged commit b41bbd9 into ansible:stable-2.8 Jun 18, 2019
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abadger abadger abadger left review comments

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mmazur @ansibot @pkliczewski @abadger