win_partition - Fix handling of maximum partition size

[varunchopra]

SUMMARY

Fixes #56910

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

win_partition

ADDITIONAL INFORMATION

Doesn't resize the partition if the difference is ~1MiB +/- from the original partition size according to my post here: #56910 (comment) This issue is prevalent in partitions with large disk sizes so it's still not covered by these integration tests.

I've also removed -UseMaximumSize and specified the maximum supported size directly.

[ansibot]

cc @ShachafGoldstein @if-meaton @jborean93 @jhawkesworth @nitzmahone
click here for bot help

[ShachafGoldstein]

Any way to test the 1mb issue in the ci?
and, maybe use 1MB and not the actual length in the if since powershell translates it and it will be more readable.

another question for the crowd, should the module send out a warning when this issue occurs?

[varunchopra]

Any way to test the 1mb issue in the ci?

I'm not sure about the free space available on the server at the time of testing. I think at the time of writing this, I kept the 1 GB partition for the sake of the CI so I'm not sure how much space is OK for us to use.

and, maybe use 1MB and not the actual length in the if since powershell translates it and it will be more readable.

I kept it in bytes to reduce conversions but I can do this is needed too.

another question for the crowd, should the module send out a warning when this issue occurs?

It would throw a warning most of the time though, making users think something is wrong with it. Not sure how to approach this either - perhaps a note in the docs?

[ShachafGoldstein]

If you'll run Measure-Command {1MB} you can see the conversion is not an issue

[varunchopra]

I'm probably wrong but it seems like the way of doing this would be to replace:

($ansible_partition_size - $ansible_partition.Size -gt 1049000 -or $ansible_partition.Size - $ansible_partition_size -gt 1049000)

with:

([Math]::Round(($ansible_partition_size - $ansible_partition.Size)/1MB) -le 1 -or [Math]::Round(($ansible_partition.Size - $ansible_partition_size)/1MB) -le 1)

Or is there another way of doing this seeing how direct conversion to MiB isn't possible?

[ShachafGoldstein]

I actually just meant replacing 104900 to 1mb :)

…

On Mon, Jun 24, 2019, 11:50 Varun Chopra ***@***.***> wrote: I'm probably wrong but it seems like the way of doing this would be to replace: ($ansible_partition_size - $ansible_partition.Size -gt 1049000 -or $ansible_partition.Size - $ansible_partition_size -gt 1049000) with: ([Math]::Round(($ansible_partition_size - $ansible_partition.Size)/1MB) - le 1 -or [Math]::Round(($ansible_partition.Size - $ansible_partition_size)/1MB) -le 1) Or is there another way of doing this seeing how direct conversion to MiB isn't possible? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#58225?email_source=notifications&email_token=ACV27RVKK3WNCQL7AIIIUETP4CDG3A5CNFSM4H2WJKZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYMHKPA#issuecomment-504919356>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACV27RREEROAPOWPQ6LXIFLP4CDG3ANCNFSM4H2WJKZA> .

[varunchopra]

It must be less than 1 MiB not 1 MB though.

[branic]

You could simplify the if statement and math by doing:

[Math]::Abs(($ansible_partition_size - $ansible_partition.Size)/1024/1024) -gt 1

The 1024/1024 could be replaced by 1048576 (or 104900), but to me the 1024/1024 is clearer.

[varunchopra]

Looking for signs of life. @jborean93 @nitzmahone Please let me know if I need to go on with this. Not sure if I'd be able to contribute later.

[jborean93]

Sorry about that @chopraaa

rebuild_merge