Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a banner message to warn when not on latest documentation #58526

Merged
merged 5 commits into from
Jun 28, 2019
Merged

Add a banner message to warn when not on latest documentation #58526

merged 5 commits into from
Jun 28, 2019

Conversation

samccann
Copy link
Contributor

SUMMARY

Adds a banner to the top of the page when a user is not on the latest release documentation.

Partially addresses #58346

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

docs.ansible.com

ADDITIONAL INFORMATION

@samccann samccann added docs This issue/PR relates to or includes documentation. affects_2.9 This issue/PR affects Ansible v2.9 labels Jun 28, 2019
@samccann samccann added this to To do in OLD Ansible Documentation via automation Jun 28, 2019
@ansibot
Copy link
Contributor

ansibot commented Jun 28, 2019

cc @acozine
click here for bot help

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jun 28, 2019
@ansibot
Copy link
Contributor

ansibot commented Jun 28, 2019

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

docs/docsite/rst/conf.py:149:21: E203 whitespace before ':'
docs/docsite/rst/conf.py:150:1: E122 continuation line missing indentation or outdented

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 28, 2019
@acozine acozine merged commit 35b6345 into ansible:devel Jun 28, 2019
agowa pushed a commit to agowa/ansible-1 that referenced this pull request Jun 30, 2019
@samccann @agowa
Add a banner message to warn when not on latest documentation (ansibl…
7b31c64 
…e#58526)

* add banner to versions that are not latest

* move div into script

* fix div

* move comment

* fix shippable errors
samccann added a commit to samccann/ansible that referenced this pull request Jul 5, 2019
@samccann
Add a banner message to warn when not on latest documentation (ansibl…
1f9a306 
…e#58526)

* add banner to versions that are not latest

* move div into script

* fix div

* move comment

* fix shippable errors

(cherry picked from commit 35b6345)
samccann added a commit to samccann/ansible that referenced this pull request Jul 5, 2019
@samccann
Add a banner message to warn when not on latest documentation (ansibl…
6e1817c 
…e#58526)

* add banner to versions that are not latest

* move div into script

* fix div

* move comment

* fix shippable errors

(cherry picked from commit 35b6345)
@samccann samccann deleted the banner branch July 5, 2019 14:24
samccann added a commit to samccann/ansible that referenced this pull request Jul 5, 2019
@samccann
Add a banner message to warn when not on latest documentation (ansibl…
3735c65 
…e#58526)

* add banner to versions that are not latest

* move div into script

* fix div

* move comment

* fix shippable errors

(cherry picked from commit 35b6345)
acozine pushed a commit that referenced this pull request Jul 5, 2019
@samccann @acozine
Add a banner message to warn when not on latest documentation (#58526) (
3d9c2e8 
#58762)

* add banner to versions that are not latest

(cherry picked from commit 35b6345)
acozine pushed a commit that referenced this pull request Jul 8, 2019
@samccann @acozine
Add a banner message to warn when not on latest documentation (#58526) (
73bbdf4 
#58767)

* add banner to versions that are not latest
(cherry picked from commit 35b6345)
acozine pushed a commit that referenced this pull request Jul 8, 2019
@samccann @acozine
Add a banner message to warn when not on latest documentation (#58526) (
4e63b68 
#58765)

* add banner to versions that are not latest
(cherry picked from commit 35b6345)
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samccann @ansibot @acozine