Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes to config manager #58530

Merged
merged 5 commits into from
Jul 17, 2019
Merged

fixes to config manager #58530

merged 5 commits into from
Jul 17, 2019

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Jun 28, 2019

dont choose unreadable config file

properly validate ALL types

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ConfigManager

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jun 28, 2019
@bcoca bcoca force-pushed the dont_chooose_unreadable_config branch from 0fe0b92 to 00cb7b8 Compare June 28, 2019 20:15
@s-hertel
Copy link
Contributor

shipit

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jun 28, 2019
@bcoca bcoca force-pushed the dont_chooose_unreadable_config branch from 00cb7b8 to 52050dc Compare June 28, 2019 21:30
@ansibot ansibot removed the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Jun 28, 2019
@Akasurde Akasurde changed the title fixes to confir manager fixes to config manager Jun 30, 2019
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Jul 1, 2019
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Jul 2, 2019
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Jul 2, 2019
@samdoran samdoran added the ci_verified Changes made in this PR are causing tests to fail. label Jul 11, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 11, 2019
@bcoca bcoca merged commit a39b721 into ansible:devel Jul 17, 2019
@bcoca bcoca deleted the dont_chooose_unreadable_config branch July 17, 2019 14:40
@AlanCoding AlanCoding mentioned this pull request Jul 23, 2019
Closed
@ansible ansible locked and limited conversation to collaborators Aug 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@s-hertel s-hertel s-hertel approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bcoca @s-hertel @mattclay @samdoran @ansibot