Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yum: check whether the lock file disappeared #58581

Merged
merged 1 commit into from
Jul 11, 2019
Merged

yum: check whether the lock file disappeared #58581

merged 1 commit into from
Jul 11, 2019

Conversation

mkrizek
Copy link
Contributor

@mkrizek mkrizek commented Jul 1, 2019

SUMMARY

Addressing concerns from #58489:

  1. use @abstractmethod instead of raise NotImplementedError
  2. wrap the body of is_lockfile_pid_valid into try: except: to check whether the lock file disappeared while we were checking for it/its contents

Also add couple of explaining comments.

cc @abadger

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

yum

@mkrizek mkrizek mentioned this pull request Jul 1, 2019
Merged
@ansibot
Copy link
Contributor

ansibot commented Jul 1, 2019

cc @Akasurde @berenddeschouwer @kustodian @maxamillion @verm666
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. packaging Packaging category support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jul 1, 2019
@mkrizek mkrizek requested a review from maxamillion July 1, 2019 12:57
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Jul 2, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 10, 2019
@sivel sivel mentioned this pull request Jul 10, 2019
Closed
@mkrizek
Copy link
Contributor Author

mkrizek commented Jul 11, 2019

For the record, I ran the CI manually and am merging this after getting a +1 from @maxamillion in a PM.

@mkrizek mkrizek merged commit b0f3893 into ansible:devel Jul 11, 2019
@mkrizek mkrizek deleted the yum-check-for-missing-lockfile branch July 11, 2019 16:14
mkrizek added a commit to mkrizek/ansible that referenced this pull request Jul 11, 2019
@mkrizek
yum: check whether the lock file disappeared (ansible#58581)
14f9c73 
(cherry picked from commit b0f3893)
@maxamillion
Copy link
Contributor

for posterity, I will echo that +1 in public

abadger pushed a commit that referenced this pull request Jul 15, 2019
@mkrizek @abadger
2.8: yum: take care of stale/invalid yum.pid (#58457) (#58489)
2807788 
* yum: take care of stale/invalid yum.pid (#58457)

* yum: take care of stale/invalid yum.pid

* Add changelog

(cherry picked from commit 5064e67)

* yum: check whether the lock file disappeared (#58581)


(cherry picked from commit b0f3893)
@ansible ansible locked and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maxamillion maxamillion Awaiting requested review from maxamillion

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. packaging Packaging category stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mkrizek @ansibot @maxamillion @bcoca