-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
win_hosts to use Ansible.Basic CSharp Util and better diff support #58600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.9
This issue/PR affects Ansible v2.9
core_review
In order to be merged, this PR must follow the core review workflow.
feature
This issue/PR relates to a feature request.
module
This issue/PR relates to a module.
needs_triage
Needs a first human triage before being processed.
owner_pr
This PR is made by the module's maintainer.
support:community
This issue/PR relates to code supported by the Ansible community.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
windows
Windows community
labels
Jul 1, 2019
jborean93
requested changes
Jul 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks great, nice to see it being simplified. Just some minor nits on the documentation changes.
ansibot
added
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
and removed
core_review
In order to be merged, this PR must follow the core review workflow.
labels
Jul 4, 2019
ansibot
added
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
stale_review
Updates were made after the last review and the last review is more than 7 days old.
labels
Jul 17, 2019
jborean93
approved these changes
Jul 21, 2019
rebuild_merge |
ansibot
added
shipit
This PR is ready to be merged by Core
and removed
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
stale_review
Updates were made after the last review and the last review is more than 7 days old.
labels
Jul 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.9
This issue/PR affects Ansible v2.9
feature
This issue/PR relates to a feature request.
module
This issue/PR relates to a module.
owner_pr
This PR is made by the module's maintainer.
shipit
This PR is ready to be merged by Core
support:community
This issue/PR relates to code supported by the Ansible community.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
windows
Windows community
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Modifies win_hosts module to use the Ansible.Basic CSharp Util instead of the legacy powershell module.
Also includes an improvement to the diff support. Instead of generating a prepared diff, it uses the before, after properties.
ISSUE TYPE
COMPONENT NAME
win_hosts
ADDITIONAL INFORMATION
I also updated the documents so that it better matches the development guide.
before diff change
after diff change