Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win_hosts to use Ansible.Basic CSharp Util and better diff support #58600

Merged
merged 3 commits into from
Jul 21, 2019

Conversation

mhunsber
Copy link
Contributor

@mhunsber mhunsber commented Jul 1, 2019

SUMMARY

Modifies win_hosts module to use the Ansible.Basic CSharp Util instead of the legacy powershell module.
Also includes an improvement to the diff support. Instead of generating a prepared diff, it uses the before, after properties.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

win_hosts

ADDITIONAL INFORMATION

I also updated the documents so that it better matches the development guide.

before diff change

TASK [win_hosts : remove aliases from the list] ***********

-[192.168.168.1 testhost alias1 alias2 alias3 alias4]
+[192.168.168.1 testhost alias1 alias2 ]

after diff change

TASK [win_hosts : remove aliases from the list] ***********

@@ -19,4 +19,4 @@
 # localhost name resolution is handled within DNS itself.
 #      127.0.0.1       localhost
 #      ::1             localhost
-192.168.168.1 testhost alias1 alias2 alias3 alias4
+192.168.168.1 testhost alias1 alias2

@ansibot
Copy link
Contributor

ansibot commented Jul 1, 2019

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community labels Jul 1, 2019
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Jul 2, 2019
Copy link
Contributor

@jborean93 jborean93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks great, nice to see it being simplified. Just some minor nits on the documentation changes.

lib/ansible/modules/windows/win_hosts.py Show resolved Hide resolved
lib/ansible/modules/windows/win_hosts.py Outdated Show resolved Hide resolved
lib/ansible/modules/windows/win_hosts.py Outdated Show resolved Hide resolved
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 4, 2019
@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. labels Jul 17, 2019
@jborean93
Copy link
Contributor

rebuild_merge

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. labels Jul 21, 2019
@jborean93 jborean93 merged commit 74598b2 into ansible:devel Jul 21, 2019
@ansible ansible locked and limited conversation to collaborators Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.9 This issue/PR affects Ansible v2.9 feature This issue/PR relates to a feature request. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants