Added support to create and delete multiple databases in MySQL

[pratikgadiya12]

SUMMARY

Creation/Deletion of multiple databases now supported in MySQL

Fixes: #58370

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

lib/ansible/modules/database/mysql/mysql_db.py

[ansibot]

cc @Alexander198961 @Andersson007 @Xyon @bmalynovytch @bmildren @michaelcoburn @Oneiroi @tolland
click here for bot help

[felixfontein]

Please rework the logic using the lists. I'll take another look then.

[Andersson007]

@pratikgadiya12 , thank you for this PR!
Let's start from covering these changes by integration tests. Then I make code and doc reviews.

1. First of all, regarding that @felixfontein said , please, remove tests in a comma-separated form or a list form (on your choice) from the test file because they are interchangeable
2. We should check:

• Create multiple databases check_mode (done)
• Create multiple databases (partially done) - you check it by: "'database%' not in mysql_result.stdout" it may return true when one db exists, but we need to be sure that the both databases exist, so, better to check them by names
• Delete multiple databases check_mode (done)
• Delete multiple databases (done)
• Recreate multiple databases (done)

Please add checks for the following case:

• As I wrote above, when we check that the databases exist on the server instance we need to be sure that each of them exists, change it please (preferably by check them by names).
• Delete one of the databases, result.changed == true
• Check that it doesn't exist and the second db exists
• Try to create both in check_mode, result.changed == true
• Check that the deleted db actually doesn't exist, the second exist
• Try to create both again in actual mode, result.changed == true
• Check that the both exist
• Remove both databases to clean up

[ansibot]

cc @acozine
click here for bot help

[pratikgadiya12]

thank you, guys, for the great work!
two points about tests:

1. IMO better to move tests that related to import to another file (suitable existent or new)
2. there are duplicated tests, @pratikgadiya12 , if you check, for example, deletion, you don't need to do it again each time when you need to delete databases for the next steps, etc. So, better to reduce amount of test code by deleting assertions that were before (you could remark in test comment that you delete databases because it's needed for the next step, etc.)
3. The module return db/db_list so, IMO better to add RETURN = r'''...''' block (see almost any postgresql modules) and check it into the tests, e.g.:

- assert:
    that:
    - result is changed
    - result.db == [..., ..., ...]

Thanks for the review @felixfontein and @Andersson007!
I have fixed all the above review comments

[Andersson007]

shipit

[Andersson007]

@pratikgadiya12 thanks for the contribution, great work, thanks!
@felixfontein , thanks for reviewing!

[pratikgadiya12]

Thanks a lot @felixfontein and @Andersson007 for great review!

We could merge this @felixfontein since this PR has 2 shipit's from you guys :)

[Andersson007]

!needs_revision

[bmalynovytch]

bot_status

[ansibot]

Components

changelogs/fragments/58370-mysqldb-allow-multiple_databases_create_delete_operation.yml
support: community
maintainers:

docs/docsite/rst/porting_guides/porting_guide_2.9.rst
support: core
maintainers: acozine

lib/ansible/modules/database/mysql/mysql_db.py
support: community
maintainers: Alexander198961 Andersson007 Xyon ansible bmalynovytch bmildren michaelcoburn oneiroi tolland

test/integration/targets/mysql_db/tasks/main.yml
support: community
maintainers: Alexander198961 Andersson007 Xyon ansible bmalynovytch bmildren michaelcoburn oneiroi tolland

test/integration/targets/mysql_db/tasks/multi_db_create_delete.yml
support: community
maintainers: Alexander198961 Andersson007 Xyon ansible bmalynovytch bmildren michaelcoburn oneiroi tolland

test/integration/targets/mysql_db/tasks/state_dump_import.yml
support: community
maintainers: Alexander198961 Andersson007 Xyon ansible bmalynovytch bmildren michaelcoburn oneiroi tolland

Metadata

waiting_on: pratikgadiya12
changes_requested_by: bmalynovytch
needs_info: False
needs_revision: True
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): False
community_shipits (namespace maintainers): False
ansible_shipits (core team members): False
shipit_actors (maintainer or core team member): None
shipit_actors_other:
automerge: automerge shipit test failed

click here for bot help

[bmalynovytch]

shipit

[felixfontein]

@pratikgadiya12 thanks a lot for implementing this!
@bmalynovytch @Andersson007 thanks a lot for reviewing!