Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

human_to_bytes: Unit tests for isbits arg of human_to_bytes function, adding explanation of isbits to the docstring #58623

Merged
merged 16 commits into from
Jul 23, 2019
Merged

human_to_bytes: Unit tests for isbits arg of human_to_bytes function, adding explanation of isbits to the docstring #58623

merged 16 commits into from
Jul 23, 2019

Conversation

Andersson007
Copy link
Contributor

@Andersson007 Andersson007 commented Jul 2, 2019 •
edited by webknjaz

Co-authored-by: Sviatoslav Sydorenko webknjaz@redhat.com

SUMMARY

  1. Unit tests for isbits arg of human_to_bytes function from lib/ansible/module_utils/common/text/formatters.py

  2. Add explanation about isbits to formatters.py and note to validation.py to clarify how the function works.

ISSUE TYPE
  • Bugfix Pull Request

@Andersson007
Copy link
Contributor Author

@samdoran , hey, as I promised yesterday there are tests for isbits. This PR also contains explanation about how the function handles isbits value.
Regarding my research, we might decide it needs refactoring or not.

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jul 2, 2019
@Andersson007 Andersson007 reopened this Jul 2, 2019
@Andersson007 Andersson007 reopened this Jul 2, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 2, 2019
@samdoran samdoran self-assigned this Jul 2, 2019
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Jul 2, 2019
@bcoca bcoca requested a review from samdoran July 2, 2019 15:37
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 2, 2019
@samdoran samdoran changed the title human_to_bytest: Unit tests for isbits arg of human_to_bytes function, adding explanation of isbits to the docstring human_to_bytes: Unit tests for isbits arg of human_to_bytes function, adding explanation of isbits to the docstring Jul 2, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 3, 2019
@Andersson007
Copy link
Contributor Author

Andersson007 commented Jul 3, 2019 •
edited

There are unrelated problems with azure tests that looks like because of #58576, so

ready_for_review

@Andersson007 Andersson007 mentioned this pull request Jul 3, 2019
Merged
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 5, 2019
@Andersson007
Copy link
Contributor Author

ready_for_review

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 5, 2019
webknjaz
webknjaz approved these changes Jul 5, 2019
View reviewed changes
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@webknjaz
Copy link
Member

webknjaz commented Jul 5, 2019

Let's wait for @samdoran to approve too.

@Andersson007 @webknjaz
Update test/units/module_utils/common/text/formatters/test_human_to_b…
ff78422 
…ytes.py

Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
@Andersson007
Copy link
Contributor Author

@webknjaz thank you for reviewing and approving , the best experience (as always)

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 5, 2019
@Andersson007 Andersson007 reopened this Jul 5, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 5, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 15, 2019
@Andersson007 Andersson007 reopened this Jul 16, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 16, 2019
@webknjaz webknjaz merged commit 3339531 into ansible:devel Jul 23, 2019
@ansible ansible locked and limited conversation to collaborators Aug 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@webknjaz webknjaz webknjaz approved these changes

@samdoran samdoran Awaiting requested review from samdoran

Assignees

@samdoran samdoran

Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Andersson007 @ansibot @webknjaz @bcoca @samdoran