Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnf - fix error formatting of module name in error message #58647

Merged
merged 3 commits into from
Jul 9, 2019
Merged

dnf - fix error formatting of module name in error message #58647

merged 3 commits into from
Jul 9, 2019

Conversation

samdoran
Copy link
Contributor

@samdoran samdoran commented Jul 2, 2019 •
edited

SUMMARY

When a failure occurs, the name of the module is incorrectly being joined with spaces:

"failures": ["s w i g : 3 . 0 / d e f a u l t Problems in request:\nmissing groups or modules: swig:3.0/default"]

This PR fixes that and it displays like this:

"failures": ["swig:3.0/default Problems in request:\nmissing groups or modules: swig:3.0/default"]
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/packaging/os/dnf.py

@samdoran samdoran requested a review from maxamillion July 2, 2019 20:40
@ansibot
Copy link
Contributor

ansibot commented Jul 2, 2019

cc @DJMuggs @berenddeschouwer @ignatenkobrain @maxamillion
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. packaging Packaging category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jul 2, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jul 3, 2019
@mkrizek mkrizek merged commit 1c2c1c1 into ansible:devel Jul 9, 2019
@ansible ansible locked and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mkrizek mkrizek mkrizek approved these changes

@maxamillion maxamillion Awaiting requested review from maxamillion

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. packaging Packaging category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samdoran @ansibot @mkrizek