Improve setup_docker tests to work with RHEL 8 GA #58649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.9
mattclay
approved these changes
Jul 2, 2019
|
The test |
ansibot
added
needs_revision
|
I think the original setup_docker was not installing anything on CentOS6 (identified as RHEL6) since setting up docker never worked there. I guess you either have to fix that, or prevent installing docker there as well. |
- use include_vars to set appropriate packages and pip packages per distribution and version - install an older versiono of Docker CE on RHEL 8 since a dependency is unavailable - disable warnings on tasks that are ok
samdoran
force-pushed
the
ci/docker-setup-tests
branch
from
0d03e0e
to
7f6fc68
Compare
ansibot
added
community_review
samdoran
added a commit
to samdoran/ansible
that referenced
this pull request
Jul 3, 2019
…le#58649) - use include_vars to set appropriate packages and pip packages per distribution and version - install an older version of Docker CE on RHEL 8 since a dependency is unavailable - disable warnings on tasks that are ok - skip tests for CentOS/RHEL 6 (cherry picked from commit d50c8c2) Co-authored-by: Sam Doran <sdoran@redhat.com>
samdoran
added a commit
to samdoran/ansible
that referenced
this pull request
Jul 3, 2019
…le#58649) - use include_vars to set appropriate packages and pip packages per distribution and version - install an older version of Docker CE on RHEL 8 since a dependency is unavailable - disable warnings on tasks that are ok - skip tests for CentOS/RHEL 6. (cherry picked from commit d50c8c2) Co-authored-by: Sam Doran <sdoran@redhat.com>
abadger
pushed a commit
that referenced
this pull request
Jul 16, 2019
- use include_vars to set appropriate packages and pip packages per distribution and version - install an older version of Docker CE on RHEL 8 since a dependency is unavailable - disable warnings on tasks that are ok - skip tests for CentOS/RHEL 6 (cherry picked from commit d50c8c2) Co-authored-by: Sam Doran <sdoran@redhat.com>
abadger
pushed a commit
that referenced
this pull request
Jul 17, 2019
- use include_vars to set appropriate packages and pip packages per distribution and version - install an older version of Docker CE on RHEL 8 since a dependency is unavailable - disable warnings on tasks that are ok - skip tests for CentOS/RHEL 6. (cherry picked from commit d50c8c2) Co-authored-by: Sam Doran <sdoran@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
include_varsto set appropriate packages and pip packages per distribution and versionISSUE TYPE
COMPONENT NAME
test/integration/targets/setup_docker/