Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMware: New Module for VMWare content Library info #58703

Merged
merged 3 commits into from
Jul 12, 2019
Merged

VMware: New Module for VMWare content Library info #58703

merged 3 commits into from
Jul 12, 2019

Conversation

pgbidkar
Copy link
Contributor

@pgbidkar pgbidkar commented Jul 4, 2019 •
edited by Akasurde

SUMMARY

New module to get list of Existing Content Libraries

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

VMWare Content Library

ADDITIONAL INFORMATION

New module to get list of Existing Content Libraries. Get details of existing content library

@ansibot
Copy link
Contributor

ansibot commented Jul 4, 2019

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_content_library_info.py:0:0: missing documentation (or could not parse documentation): invalid syntax (<unknown>, line 6)

The test ansible-test sanity --test compile --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_content_library_info.py:6:1: SyntaxError:

The test ansible-test sanity --test line-endings [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_content_library_info.py:0:0: use "\n" for line endings instead of "\r\n"

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jul 4, 2019

cc @Akasurde @Tomorrow9 @goneri @lparkes @warthog9
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 ci_verified Changes made in this PR are causing tests to fail. cloud module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community labels Jul 4, 2019
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Jul 4, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 4, 2019

@GBrawl @MikeKlebolt @Tomorrow9 @alongchamps @bedecarroll @CastawayEGR @chrrrles @dav1x @davidmhewitt @garbled1 @GyorgyPeter @imjoseangel @jjahns @kamsz @karstenjakobsen @kryptsi @lrivallain @michaeldeaton @nafpliot-ibm @nerzhul @oboukili @ritzk @rmin @stravassac @sumkincpp @vmwjoseph @warthog9 @woshihaoren

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 4, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 4, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py:198:69: E128 continuation line under-indented for visual indent

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jul 4, 2019

@pgbidkar this PR contains more than one new module.

Please submit only one new module per pull request. For a detailed explanation, please read the grouped modules documentation

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. community_review In order to be merged, this PR must follow the community review workflow. and removed community_review In order to be merged, this PR must follow the community review workflow. ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 4, 2019
@Akasurde Akasurde self-assigned this Jul 5, 2019
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Jul 5, 2019
@Akasurde Akasurde requested review from jillr and goneri July 5, 2019 10:43
Akasurde
Akasurde requested changes Jul 5, 2019
View reviewed changes
Copy link
Member

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes, rest LGTM

@Akasurde Akasurde changed the title New Module for VMWare content Library Facts VMware: New Module for VMWare content Library Facts Jul 5, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jul 5, 2019
@pgbidkar
Copy link
Contributor Author

pgbidkar commented Jul 5, 2019

Thanks @Akasurde for the review comments. committed new changes. Please review

jillr
jillr reviewed Jul 5, 2019
View reviewed changes
Copy link
Contributor

@jillr jillr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Module lgtm when test comments are resolved.

test/integration/targets/vmware_content_library/content_lib_details.yml Outdated Show resolved Hide resolved
pgbidkar
pgbidkar commented Jul 9, 2019
View reviewed changes
Copy link
Contributor Author

@pgbidkar pgbidkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @goneri, Thanks for review comments. Please let me know your inputs for my queries.

Thanks

lib/ansible/modules/cloud/vmware/vmware_content_library_info.py Outdated Show resolved Hide resolved
lib/ansible/modules/cloud/vmware/vmware_content_library_info.py Outdated Show resolved Hide resolved
test/integration/targets/vmware_content_library/aliases Outdated Show resolved Hide resolved
test/integration/targets/vmware_content_library/tasks/content_lib_details.yml Outdated Show resolved Hide resolved
test/integration/targets/vmware_content_library/tasks/content_lib_details.yml Outdated Show resolved Hide resolved
test/integration/targets/vmware_content_library/tasks/main.yml Outdated Show resolved Hide resolved
pgbidkar
pgbidkar commented Jul 10, 2019
View reviewed changes
Copy link
Contributor Author

@pgbidkar pgbidkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @goneri , Did the changes. please review

lib/ansible/modules/cloud/vmware/vmware_content_library_info.py Outdated Show resolved Hide resolved
test/integration/targets/vmware_content_library/tasks/content_lib_details.yml Outdated Show resolved Hide resolved
@ansibot
Copy link
Contributor

ansibot commented Jul 10, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_content_library_info.py:107:8: bare-except No exception type(s) specified

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_content_library_info.py:107:9: E722 do not use bare 'except'

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Jul 10, 2019
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Jul 10, 2019
@goneri
Copy link
Contributor

goneri commented Jul 10, 2019

Thanks @pgbidkar for the reactivity. It looks good to me.

@pgbidkar @Akasurde
New Module for VMWare content Library Facts
2e5d699 
Changes as per review comments and renamed file to vmware_content_library_info

Removing password field from publish info dictionary

Removed current password field from publish info

Modfied vmware_content_library_info module with review comments. Adding new module for content library manager

Adding integration tests for content library

Fixing format issue. Converted dos2unix

Fixed precheck test failures

Fixing some more precheck Errors

Fixed few format issues in vmware_content_library_info. Deleting vmware_content_library_manager module as 2 modules are not allowed in same commit

Fixed documentation format issue

Fixing format issue. Converted dos2unix
@pgbidkar @Akasurde
New Module for content library CRUD operations. Integration test to t…
5d5c2fe 
…est the module
@pgbidkar @Akasurde
Deleting new module from this PR. By mistake added new module to same…
6457adf 
… branch

Changes as per review comments

Review comments. Moved test .yml files under tasks folder

Moved test files under module name folder. Handled library_get call under try catch to throw proper error message

Fixed precheck failure bare except. Catching Exception
@Akasurde Akasurde changed the title VMware: New Module for VMWare content Library Facts VMware: New Module for VMWare content Library info Jul 12, 2019
@Akasurde Akasurde merged commit 6bd6bf9 into ansible:devel Jul 12, 2019
@ansible ansible locked and limited conversation to collaborators Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jillr jillr jillr left review comments

@goneri goneri goneri approved these changes

@Akasurde Akasurde Akasurde approved these changes

Assignees

@Akasurde Akasurde

Labels
affects_2.9 This issue/PR affects Ansible v2.9 cloud module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pgbidkar @ansibot @goneri @Akasurde @jillr